Fix assert_expected_events macro

[claravanstaden]

Description

The assert_expected_events does not correctly check event fields. Even though the provided field values do not match, the macro did not raise an error.

Review Notes

The meet_conditions variable kept being reset to true, which means that conditions not met would be overwritten with a positive value.

Closes: #2460

[bkontur]

@claravanstaden can you also please check this #2460 - if it is related or the same problem? And if so, please close with this PR?

[claravanstaden]

Closing as a duplicate of #2460.

[acatangiu]

#2460 is just an issue, not a PR, this PR is not a duplicate

[claravanstaden]

I think I fixed the macro, but need to fix all the failing tests now. 😅

[acatangiu]

I think I fixed the macro, but need to fix all the failing tests now. 😅

🙈 that is some noble task ❤️

[acatangiu]

I think I fixed the macro, but need to fix all the failing tests now. 😅

if any of them are complicated to fix, feel free to tag the git blame test/check author on them for help

[claravanstaden]

cargo test -p asset-hub-rococo-integration-tests -p asset-hub-westend-integration-tests -p bridge-hub-rococo-integration-tests -p bridge-hub-westend-integration-tests -p collectives-westend-integration-tests -p coretime-rococo-integration-tests -p coretime-westend-integration-tests -p people-westend-integration-tests -p people-rococo-integration-tests

failures:
    tests::hybrid_transfers::bidirectional_teleport_foreign_asset_between_para_and_asset_hub_using_explicit_transfer_types
    tests::hybrid_transfers::transfer_foreign_assets_from_para_to_asset_hub
    tests::hybrid_transfers::transfer_native_asset_from_relay_to_para_through_asset_hub
    tests::reserve_transfer::reserve_transfer_multiple_assets_from_asset_hub_to_para
    tests::reserve_transfer::reserve_transfer_multiple_assets_from_para_to_asset_hub
    tests::reserve_transfer::reserve_transfer_native_asset_from_para_to_asset_hub
    tests::reserve_transfer::reserve_transfer_native_asset_from_para_to_relay
    tests::reserve_transfer::reserve_transfer_native_asset_from_relay_to_para
    tests::reserve_transfer::reserve_transfer_usdt_from_asset_hub_to_para
    tests::reserve_transfer::reserve_transfer_usdt_from_para_to_para_through_asset_hub
    tests::teleport::bidirectional_teleport_foreign_assets_between_para_and_asset_hub
    tests::teleport::limited_teleport_native_assets_from_system_para_to_relay_fails
    tests::xcm_fee_estimation::multi_hop_pay_fees_works

[claravanstaden]

@franciscoaguirre for multi_hop_pay_fees_works, the expected amount for the burn event is 1000000000000, but the actual amount in the event is 966873920000. Probably a part of it was used to pay for fees? I want to update the tests but just make sure with you if it is OK. I want to remove the amount or change it to something like: amount: *amount >= test.args.amount *.9 (i.e. the amount burned should at least be higher than 90% of the test amount).