-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AHM] Revert some AH-next staking changes from master #7937
Conversation
)" This reverts commit 669b889.
@@ -1874,7 +1874,6 @@ pub mod migrations { | |||
parachains_shared::migration::MigrateToV1<Runtime>, | |||
parachains_scheduler::migration::MigrateV2ToV3<Runtime>, | |||
pallet_staking::migrations::v16::MigrateV15ToV16<Runtime>, | |||
pallet_staking::migrations::v17::MigrateV16ToV17<Runtime>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately we have already upgraded westend to V17.. you can check in the chain state.
What did this migration do? We need to see if any special consideration is needed for it or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far looks good, but it is hard to get a picture before the last PR is also reverted.
@@ -36,7 +36,7 @@ where | |||
|
|||
let all_stakers = Ledger::<T>::iter().map(|(ctrl, l)| (ctrl, l.stash)).collect::<BTreeSet<_>>(); | |||
let mut all_exposed = BTreeSet::new(); | |||
ErasStakersPaged::<T>::iter().for_each(|((_era, val, _page), expo)| { | |||
ErasStakers::<T>::iter().for_each(|(_, val, expo)| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be reverted.
ErasStakers::<T>::iter().for_each(|(_, val, expo)| { | |
ErasStakersPaged::<T>::iter().for_each(|((_era, val, _page), expo)| { |
Closed in favour of #7939 |
Related to #7858 (comment)
Reverts :