XCM executor: refund unused swapped fees #7945
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrshiposha
changed the title
acatangiu
reviewed
Mar 18, 2025
Comment on lines
+606
to
+613
| let (needed, change) = Self::get_fungible_needed_and_change( | ||
| swapped_asset, | ||
| &asset_needed_for_fees.id, | ||
| &asset_to_pay_for_fees.id, | ||
| ) | ||
| .ok_or(XcmError::FeesNotMet)?; | ||
|
|
||
| self.deposit_fee_asset(change, fees_source)?; |
There was a problem hiding this comment.
what is the scenario where there is leftover of the source asset after swapping to target asset?
I see that we are quoting the price just before doing the swap so it should be exact swap with no change.
There was a problem hiding this comment.
Ooph. Apparently, I got confused. Also, I was actually focused on another thing — simplifying the WeightTrader, where I wanted to use the AssetExchanger (I wanted this to allow general implementation of xcmPaymentApi.queryWeightToAssetFee, see the end of this comment).
I'm closing this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the XCM executor to refund the unused swapped fees into the corresponding fees source (jit withdraw, holding register, or fees register).