-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update transfer token gas and fee #7947
Open
alistair-singh
wants to merge
6
commits into
paritytech:master
Choose a base branch
from
alistair-singh:alistair/transfer-token-gas
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update transfer token gas and fee #7947
alistair-singh
wants to merge
6
commits into
paritytech:master
from
alistair-singh:alistair/transfer-token-gas
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acatangiu
approved these changes
Mar 18, 2025
Co-authored-by: Adrian Catangiu <[email protected]>
claravanstaden
approved these changes
Mar 18, 2025
@@ -641,7 +641,7 @@ pub mod bridging { | |||
/// (initially was calculated by test `OutboundQueue::calculate_fees` - ETH/ROC 1/400 and fee_per_gas 20 GWEI = 2200698000000 + *25%) | |||
/// Needs to be more than fee calculated from DefaultFeeConfig FeeConfigRecord in snowbridge:parachain/pallets/outbound-queue/src/lib.rs | |||
/// Polkadot uses 10 decimals, Kusama and Rococo 12 decimals. | |||
pub const DefaultBridgeHubEthereumBaseFee: Balance = 2_750_872_500_000; | |||
pub const DefaultBridgeHubEthereumBaseFee: Balance = 3_833_568_200_000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could probably add the value here and then reuse: https://github.com/paritytech/polkadot-sdk/blob/master/cumulus/parachains/runtimes/constants/src/westend.rs#L172 Not a major issue though
franciscoaguirre
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A4-needs-backport
Pull request must be backported to all maintained releases.
T15-bridges
This PR/Issue is related to bridges.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the gas allowance of the
TransferToken
command. This also means that the default fee needs to be increased as well as a result.In Polkadot mainnet we will have to co-ordinate this release with a runtime update which updates the Asset Hub fee accordingly.
TODO