Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transfer token gas and fee #7947

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

alistair-singh
Copy link
Contributor

@alistair-singh alistair-singh commented Mar 17, 2025

Update the gas allowance of the TransferToken command. This also means that the default fee needs to be increased as well as a result.

In Polkadot mainnet we will have to co-ordinate this release with a runtime update which updates the Asset Hub fee accordingly.

TODO

  • Add migration to half fee on bridge on start-up

@acatangiu acatangiu added T15-bridges This PR/Issue is related to bridges. A4-needs-backport Pull request must be backported to all maintained releases. labels Mar 18, 2025
@acatangiu acatangiu requested a review from a team March 18, 2025 08:39
Co-authored-by: Adrian Catangiu <[email protected]>
@@ -641,7 +641,7 @@ pub mod bridging {
/// (initially was calculated by test `OutboundQueue::calculate_fees` - ETH/ROC 1/400 and fee_per_gas 20 GWEI = 2200698000000 + *25%)
/// Needs to be more than fee calculated from DefaultFeeConfig FeeConfigRecord in snowbridge:parachain/pallets/outbound-queue/src/lib.rs
/// Polkadot uses 10 decimals, Kusama and Rococo 12 decimals.
pub const DefaultBridgeHubEthereumBaseFee: Balance = 2_750_872_500_000;
pub const DefaultBridgeHubEthereumBaseFee: Balance = 3_833_568_200_000;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could probably add the value here and then reuse: https://github.com/paritytech/polkadot-sdk/blob/master/cumulus/parachains/runtimes/constants/src/westend.rs#L172 Not a major issue though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A4-needs-backport Pull request must be backported to all maintained releases. T15-bridges This PR/Issue is related to bridges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants