Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure proper shutdown when crashing in a thread #2332

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Mar 4, 2025

What does this implement/fix?

Signal to the main process to shut down if a crash happens in a thread instead of trying to shut down cleanly from within this thread. Ensures that the non-success exit code is returned at the end, allowing systemd to try automatically restarting FTL.


Related issue or feature (if applicable): Reported as part of #2307

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

@DL6ER DL6ER added the Bugfix label Mar 4, 2025
@DL6ER DL6ER requested a review from a team March 4, 2025 16:47
@DL6ER DL6ER mentioned this pull request Mar 4, 2025
5 tasks
@yubiuser
Copy link
Member

yubiuser commented Mar 4, 2025

Build failed. And needs a rebase.

@DL6ER DL6ER force-pushed the fix/thread_crash branch from 783b88f to 741b4d9 Compare March 4, 2025 18:19
@DL6ER
Copy link
Member Author

DL6ER commented Mar 4, 2025

Not sure what happened here, probably too late yesterday... Rebased on latest development and force-pushed.

@DL6ER DL6ER force-pushed the fix/thread_crash branch from 741b4d9 to 6a32b8a Compare March 4, 2025 18:21
@DL6ER DL6ER merged commit f879ee0 into development Mar 6, 2025
19 checks passed
@DL6ER DL6ER deleted the fix/thread_crash branch March 6, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants