Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Versions] Add new complex types #1115

Merged
merged 56 commits into from
Mar 21, 2025
Merged

Conversation

ValeriaMaltseva
Copy link
Contributor

@ValeriaMaltseva ValeriaMaltseva commented Mar 11, 2025

Task: #987

What has been done as part of this PR:

  • Added the logic for the "Objects Bricks" type.
  • Added the logic for the "Field Collections" type.
  • Added the logic for the "Block" type.
  • Updated the common logic for rendering the version layout.
  • Updated styles.

Copilot

This comment was marked as resolved.

ValeriaMaltseva and others added 2 commits March 11, 2025 11:57
* added the processVersionFieldData for the FieldCollection and upodated the processLayoutData

* added the processVersionFieldData for the Block type and updated the getFormattedDataStructure

* Automatic frontend build

---------

Co-authored-by: ValeriaMaltseva <11871778+ValeriaMaltseva@users.noreply.github.com>
@ValeriaMaltseva ValeriaMaltseva marked this pull request as draft March 12, 2025 11:36
@ValeriaMaltseva ValeriaMaltseva changed the title [Versions] Add the logic for the "Objects Bricks" type [Versions] Add new complex types Mar 12, 2025
@ValeriaMaltseva ValeriaMaltseva removed the request for review from markus-moser March 12, 2025 11:44
@ValeriaMaltseva ValeriaMaltseva force-pushed the 987-update-data-object-type-4 branch from 4c5b9cd to f25cd07 Compare March 12, 2025 13:50
@ValeriaMaltseva ValeriaMaltseva force-pushed the 987-update-data-object-type-4 branch from f25081b to 2d3bc1a Compare March 13, 2025 10:12
@ValeriaMaltseva ValeriaMaltseva force-pushed the 987-update-data-object-type-4 branch from 357f3c5 to 68d18fa Compare March 13, 2025 16:32
@markus-moser
Copy link
Contributor

For the table data types we still don't have a (yellow) modified attribute indicator:

image

@markus-moser
Copy link
Contributor

I get this error when I try to compare the versions of a news object (which contains field collections):

image

@markus-moser
Copy link
Contributor

When I try to compare blocks I get the following screen:

image

It seems that for some reason this uses a massive amount of memory - I used only a very simple block:

image

@ValeriaMaltseva ValeriaMaltseva force-pushed the 987-update-data-object-type-4 branch from 9f5a1da to 0b4b60a Compare March 20, 2025 11:52
@ValeriaMaltseva ValeriaMaltseva force-pushed the 987-update-data-object-type-4 branch from 6c0aa1e to 93dfa1b Compare March 20, 2025 16:51
@ValeriaMaltseva ValeriaMaltseva force-pushed the 987-update-data-object-type-4 branch from 20616de to d0382bd Compare March 20, 2025 16:57
@ValeriaMaltseva ValeriaMaltseva force-pushed the 987-update-data-object-type-4 branch from 12b1779 to 0cb9dcd Compare March 20, 2025 18:11
Copy link
Contributor

@markus-moser markus-moser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was not able to test it but please lets merge it and do fixes in follow-up PRs

@ValeriaMaltseva ValeriaMaltseva merged commit d62eb21 into 1.x Mar 21, 2025
@ValeriaMaltseva ValeriaMaltseva deleted the 987-update-data-object-type-4 branch March 21, 2025 15:22
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants