Added paste options to context-menu
#1117
Conversation
…text-menu-actions-paste-options' into 950-missing-tree-data-object-context-menu-actions-paste-options
assets/js/src/core/modules/data-object/actions/paste/use-paste.tsx
Outdated
Show resolved
Hide resolved
| return isPasteOpenHidden(node) || | ||
| node.type === 'folder' || | ||
| node.isLocked | ||
| // storedNode?.type !== node.type //TODO: i guess we need to compare the className aswell |
There was a problem hiding this comment.
Yes for paste only contents we need to compare the class name
There was a problem hiding this comment.
Funfact: in the old UI we dont check the className ... you can select paste only contentfrom acarto aevent`
| const isPasteOpenHidden = (node: Element | TreeNodeProps): boolean => { | ||
| return !isTreeActionAllowed(TreePermission.Paste) || | ||
| (storedNode === undefined || nodeTask !== 'copy') || | ||
| !checkElementPermission(node.permissions, 'create') |
There was a problem hiding this comment.
Do we need to check the locked status too?
There was a problem hiding this comment.
nope at least in the old UI its not respected ...
| hidden: isPasteOpenHidden(node), | ||
| onClick: async () => { | ||
| dispatch(setNodeFetching({ treeId, nodeId: String(node.id), isFetching: true })) | ||
| await paste(parseInt(node.id), { recursive: true, updateReferences: false }, storedNode) |
There was a problem hiding this comment.
why do we need to pass the storedNode?
There was a problem hiding this comment.
Because node is the currently clicked one and the storedNode is the copied one. Or did i miss something?
|
Changes in this pull request
Partly-Resolves #950
Blocked-by: pimcore/studio-backend-bundle#890
Additional info
This pull request introduces a new
usePastehook and integrates it into the context menu for data objects, enhancing the copy-paste functionality. The main changes include the addition of new paste options and the removal of redundant code.Enhancements to copy-paste functionality:
assets/js/src/core/modules/data-object/actions/paste/use-paste.tsx: Introduced a newusePastehook with multiple paste options, such aspasteAsChildRecursiveTreeContextMenuItem,pasteRecursiveUpdatingReferencesTreeContextMenuItem,pasteAsChildTreeContextMenuItem,pasteOnlyContentsTreeContextMenuItem, andisPasteMenuHidden.Integration into context menu:
assets/js/src/core/modules/data-object/tree/context-menu/context-menu.tsx: Integrated the newusePastehook into the data object tree context menu, adding new paste options and removing redundant paste items. [1] [2]Refactoring of
useCopyPaste:assets/js/src/core/modules/element/actions/copy-paste/use-copy-paste.tsx: Refactored theuseCopyPastehook to support the new paste options and removed the oldpasteContextMenuItemmethod. [1] [2] [3] [4] [5]Translation updates:
translations/studio.en.yaml: Added new translation keys for the new paste options.