-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added unpublish
context-menu option
#1139
Open
Corepex
wants to merge
22
commits into
1.x
Choose a base branch
from
950-missing-tree-data-object-context-menu-actions-unpublish-option
base: 1.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Added unpublish
context-menu option
#1139
Corepex
wants to merge
22
commits into
1.x
from
950-missing-tree-data-object-context-menu-actions-unpublish-option
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
…ions-unpublish-option
…text-menu-actions-unpublish-option' into 950-missing-tree-data-object-context-menu-actions-unpublish-option
…ions-unpublish-option
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves #950
Additional info
This pull request includes several changes to the data object module, with a focus on enhancing the handling of data object tasks, improving the toolbar save buttons, and updating the context menu for data objects. The most important changes are summarized below:
Enhancements to data object task handling:
assets/js/src/core/modules/data-object/actions/add-object/use-add-object.tsx
: ModifiedopenDataObject
calls to usevoid
for better type safety. [1] [2] [3] [4]assets/js/src/core/modules/data-object/hooks/use-data-object-helper.ts
: AddedexecuteDataObjectTask
function to handle data object tasks and updatedopenDataObject
to return aPromise<void>
. [1] [2]Improvements to toolbar save buttons:
assets/js/src/core/modules/data-object/editor/toolbar/save-buttons/save-buttons.tsx
: AddedexecuteDataObjectTask
to handle unpublish tasks and updated the toolbar to include an unpublish button if the user has the necessary permissions. [1] [2] [3]Updates to context menu for data objects:
assets/js/src/core/modules/data-object/tree/context-menu/context-menu.tsx
: Added unpublish option to the context menu for data objects. [1] [2] [3]assets/js/src/core/modules/element/actions/unpublish/use-unpublish.tsx
: Created a new hookuseUnpublish
to handle unpublish actions for tree nodes.General improvements and code cleanup:
assets/js/src/core/modules/element/hooks/use-element-helper.ts
: AddedexecuteElementTask
to handle element tasks and updatedopenElement
to usevoid
for better type safety. [1] [2] [3] [4]public/build/5e66dd34-37f5-494e-a9e2-f9ea45833dc8/main.js.LICENSE.txt
and updatedentrypoints.json
for asset management. [1] [2]