Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12025] Validate applicationName and agentId using StringPrecondition #12160

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Mar 13, 2025

No description provided.

@emeroad emeroad added this to the 3.1.0 milestone Mar 13, 2025
@emeroad emeroad linked an issue Mar 13, 2025 that may be closed by this pull request
@emeroad emeroad force-pushed the #12025_applicationName branch 4 times, most recently from 7ff7c88 to 3d4e1d0 Compare March 14, 2025 01:39
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

Attention: Patch coverage is 36.17021% with 30 lines in your changes missing coverage. Please review.

Project coverage is 33.45%. Comparing base (53d0977) to head (3d4e1d0).

Files with missing lines Patch % Lines
...vercorp/pinpoint/common/server/bo/AgentInfoBo.java 0.00% 4 Missing ⚠️
...om/navercorp/pinpoint/common/server/bo/SpanBo.java 33.33% 4 Missing ⚠️
...ntrace/web/entity/ExceptionGroupSummaryEntity.java 0.00% 2 Missing ⚠️
.../pinpoint/otlp/collector/model/OtlpMetricData.java 33.33% 2 Missing ⚠️
...int/otlp/web/service/OtlpMetricWebServiceImpl.java 0.00% 2 Missing ⚠️
...com/navercorp/pinpoint/realtime/dto/ATCDemand.java 0.00% 2 Missing ⚠️
...com/navercorp/pinpoint/realtime/dto/ATCSupply.java 0.00% 2 Missing ⚠️
...uristat/web/util/UriStatSummaryQueryParameter.java 0.00% 2 Missing ⚠️
...java/com/navercorp/pinpoint/web/vo/AgentParam.java 0.00% 2 Missing ⚠️
...nt/web/vo/activethread/AgentActiveThreadCount.java 0.00% 2 Missing ⚠️
... and 6 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12160      +/-   ##
============================================
+ Coverage     33.43%   33.45%   +0.01%     
  Complexity    10579    10579              
============================================
  Files          3848     3847       -1     
  Lines         91267    91239      -28     
  Branches       9729     9729              
============================================
+ Hits          30517    30521       +4     
+ Misses        58110    58079      -31     
+ Partials       2640     2639       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@emeroad emeroad force-pushed the #12025_applicationName branch 3 times, most recently from fd76dfa to 6cb7358 Compare March 14, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Experimental V4 Id feature
1 participant