-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade polkadot-sdk
to stable2412
#1595
Conversation
Now, it's blocked as this rust-ethereum/evm#305 |
b9954f4
to
5ae383a
Compare
Please merge master and fix those tests. Thanks! |
I am struggling with integration testing and I estimate it will take me some time to complete the work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I leave comments on parts where Deref
is not necessarily required. As for the SelfContained
, I haven’t been able to review it in depth yet, but I will take the time to revisit it.
Spent sometime yday looking at the changes, seems like all the failing tests are due to InvalidParams error from RPC from what I see. I suppose something changes in the rlp or evm versions that got bumped @0xbillw |
I started receiving similar errors after updating to 2409 and have been experiencing issues after updating to 2412. Invalid Param when retrieving the receipt, hanging transactions... Overall, it works, but about 10% of the tests fail unpredictably |
@0xbillw Nice catch! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall make sense!
|
Hi, I just would like to ask: when can this PR be merged? I am one of the users waiting for a new |
Hi everyone, I’m looking forward to using these updates on Moonbeam. If there’s anything I can do to help move this forward, please let me know. |
I noticed a few issues in the changes on |
@0xbillw No critical issues are found. Please refer to conr2d/frontier@df360d6 for removing non-essential trait bounds from |
@conr2d Thank you very much! I overlooked this part; could you merge the code? |
@0xbillw I don't have permission. Only maintainers can modify a PR except for the author. @boundless-forest, could you grant me permission? I won’t merge other PRs arbitrarily without a review. |
You can open a PR on author's fork targeting branch from this PR |
Even though "Co-authored by" will show the original author, it changes the PR author to me. I think I've left all the necessary reviews. It would be best for the maintainers to decide on the remaining matters. |
these changes are based on the [suggestions](conr2d@df360d6) from @conr2d.
…is a best practice.
@conr2d I have copied your changes. Thank you very much. |
Sorry for the delay, I don't have the permission to give you more access. I'll review this today. |
The main reason for the upgrade is to try to resolve the memory leak issue in
polkadot-sdk
stable2409
, but this PR has not been backported tostable2409
.