Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade polkadot-sdk to stable2412 #1595

Merged
merged 6 commits into from
Feb 17, 2025

Conversation

0xbillw
Copy link
Contributor

@0xbillw 0xbillw commented Jan 18, 2025

The main reason for the upgrade is to try to resolve the memory leak issue in polkadot-sdk stable2409, but this PR has not been backported to stable2409.

@0xbillw
Copy link
Contributor Author

0xbillw commented Jan 18, 2025

Now, it's blocked as this rust-ethereum/evm#305

@0xbillw 0xbillw force-pushed the stable2412 branch 2 times, most recently from b9954f4 to 5ae383a Compare January 21, 2025 04:17
@boundless-forest
Copy link
Collaborator

Please merge master and fix those tests. Thanks!

@0xbillw
Copy link
Contributor Author

0xbillw commented Jan 21, 2025

I am struggling with integration testing and I estimate it will take me some time to complete the work.

Copy link
Contributor

@conr2d conr2d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I leave comments on parts where Deref is not necessarily required. As for the SelfContained, I haven’t been able to review it in depth yet, but I will take the time to revisit it.

@vedhavyas
Copy link
Contributor

vedhavyas commented Jan 30, 2025

I am struggling with integration testing and I estimate it will take me some time to complete the work.

Spent sometime yday looking at the changes, seems like all the failing tests are due to InvalidParams error from RPC from what I see. I suppose something changes in the rlp or evm versions that got bumped @0xbillw

@vklachkov
Copy link

I started receiving similar errors after updating to 2409 and have been experiencing issues after updating to 2412. Invalid Param when retrieving the receipt, hanging transactions... Overall, it works, but about 10% of the tests fail unpredictably

@vedhavyas
Copy link
Contributor

@0xbillw Nice catch!

Copy link
Contributor

@vedhavyas vedhavyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall make sense!

@0xbillw
Copy link
Contributor Author

0xbillw commented Feb 5, 2025

I leave comments on parts where Deref is not necessarily required. As for the SelfContained, I haven’t been able to review it in depth yet, but I will take the time to revisit it.
@conr2d Thank you for your review and guidance; I have made all the necessary changes.

@BillyWooo
Copy link

Hi, I just would like to ask: when can this PR be merged? I am one of the users waiting for a new stable2412 release branch. It will be really appreciated. 👍

@manuelmauro
Copy link
Contributor

Hi everyone, I’m looking forward to using these updates on Moonbeam. If there’s anything I can do to help move this forward, please let me know.

@conr2d
Copy link
Contributor

conr2d commented Feb 10, 2025

I noticed a few issues in the changes on fp-self-contained. It would be better to address these before merging the PR. I'll provide a detailed review tomorrow.

@conr2d
Copy link
Contributor

conr2d commented Feb 11, 2025

@0xbillw No critical issues are found. Please refer to conr2d/frontier@df360d6 for removing non-essential trait bounds from fp-self-contained. For transaction pool, it might be better to address it in a separated PR.

@0xbillw
Copy link
Contributor Author

0xbillw commented Feb 14, 2025

@0xbillw No critical issues are found. Please refer to conr2d/frontier@df360d6 for removing non-essential trait bounds from fp-self-contained. For transaction pool, it might be better to address it in a separated PR.

@conr2d Thank you very much! I overlooked this part; could you merge the code?

@conr2d
Copy link
Contributor

conr2d commented Feb 14, 2025

@0xbillw I don't have permission. Only maintainers can modify a PR except for the author.
You can cherry-pick this commit if you add my repo as a remote one.

@boundless-forest, could you grant me permission? I won’t merge other PRs arbitrarily without a review.

@nazar-pc
Copy link

@0xbillw I don't have permission. Only maintainers can modify a PR except for the author.

You can open a PR on author's fork targeting branch from this PR

@conr2d
Copy link
Contributor

conr2d commented Feb 15, 2025

You can open a PR on author's fork targeting branch from this PR

Even though "Co-authored by" will show the original author, it changes the PR author to me. I think I've left all the necessary reviews. It would be best for the maintainers to decide on the remaining matters.

these changes are based on the [suggestions](conr2d@df360d6) from @conr2d.
@0xbillw
Copy link
Contributor Author

0xbillw commented Feb 17, 2025

@0xbillw No critical issues are found. Please refer to conr2d/frontier@df360d6 for removing non-essential trait bounds from fp-self-contained. For transaction pool, it might be better to address it in a separated PR.

@conr2d I have copied your changes. Thank you very much.

@boundless-forest
Copy link
Collaborator

@boundless-forest, could you grant me permission? I won’t merge other PRs arbitrarily without a review.

Sorry for the delay, I don't have the permission to give you more access. I'll review this today.

@boundless-forest boundless-forest merged commit 986eb1a into polkadot-evm:master Feb 17, 2025
4 checks passed
@0xbillw 0xbillw deleted the stable2412 branch February 20, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants