minor updates to the 'From Source' page #1222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The part about "a wide array of architectures and operating systems" predates the dependency on Envoy. Currently Pomerium is limited by the OSes/architectures supported by Envoy, which I believe includes only Linux and macOS, for amd64 and arm64. (According to an announcement at https://groups.google.com/g/envoy-announce/c/2e-mSnit_BQ/m/VvweUrdaAAAJ Windows is no longer supported after Envoy 1.27.) As of pomerium/pomerium@faa2a86 golangci-lint is no longer required to be installed locally (it is instead invoked via `go run`). Finally, make sure "Pomerium" is capitalized consistently.
✅ Deploy Preview for pomerium-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ZPain8464
approved these changes
Feb 5, 2024
|
@kenjenkins thanks for updating this page :) |
backport-actions-token bot
pushed a commit
that referenced
this pull request
Feb 5, 2024
The part about "a wide array of architectures and operating systems" predates the dependency on Envoy. Currently Pomerium is limited by the OSes/architectures supported by Envoy, which I believe includes only Linux and macOS, for amd64 and arm64. (According to an announcement at https://groups.google.com/g/envoy-announce/c/2e-mSnit_BQ/m/VvweUrdaAAAJ Windows is no longer supported after Envoy 1.27.) As of pomerium/pomerium@faa2a86 golangci-lint is no longer required to be installed locally (it is instead invoked via `go run`). Finally, make sure "Pomerium" is capitalized consistently.
kenjenkins
added a commit
that referenced
this pull request
Feb 6, 2024
minor updates to the 'From Source' page (#1222) The part about "a wide array of architectures and operating systems" predates the dependency on Envoy. Currently Pomerium is limited by the OSes/architectures supported by Envoy, which I believe includes only Linux and macOS, for amd64 and arm64. (According to an announcement at https://groups.google.com/g/envoy-announce/c/2e-mSnit_BQ/m/VvweUrdaAAAJ Windows is no longer supported after Envoy 1.27.) As of pomerium/pomerium@faa2a86 golangci-lint is no longer required to be installed locally (it is instead invoked via `go run`). Finally, make sure "Pomerium" is capitalized consistently. Co-authored-by: Kenneth Jenkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The part about "a wide array of architectures and operating systems" predates the dependency on Envoy. Currently Pomerium is limited by the OSes/architectures supported by Envoy, which I believe includes only Linux and macOS, for amd64 and arm64. (According to an announcement at https://groups.google.com/g/envoy-announce/c/2e-mSnit_BQ/m/VvweUrdaAAAJ Windows is no longer supported after Envoy 1.27.)
As of pomerium/pomerium@faa2a86 golangci-lint is no longer required to be installed locally (it is instead invoked via
go run).Finally, make sure "Pomerium" is capitalized consistently.