Updates service account admonition #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pomerium-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kenjenkins
approved these changes
Feb 21, 2024
|
|
||
| `[user-id]@[namespace-reference]` | ||
| `{user-id}@{namespace-reference}.pomerium` |
There was a problem hiding this comment.
Would namespace-id be clearer than namespace-reference here?
backport-actions-token bot
pushed a commit
that referenced
this pull request
Feb 21, 2024
updates service account admonition
ZPain8464
added a commit
that referenced
this pull request
Feb 21, 2024
Updates service account admonition (#1258) updates service account admonition Co-authored-by: zachary painter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reading @wasaga's Service Accounts RFC, I realized the format of a SA created in a non-global Namespace included in an admonition in
/docs/capabilities/enterprise-apiwas incorrect. This PR updates the format.