-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds ip range lookup support #1262
Conversation
✅ Deploy Preview for pomerium-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
content/docs/integrations.mdx
Outdated
|
||
## IP range lookup support | ||
|
||
Pomerium supports Classless Inter-Domain Routing (CIDR) indexing to improve database querying performance. This is useful if you're importing a list of records containing IP ranges. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The thing I was surprised about was the ability to match on IP address ranges at all (setting aside any questions to do with performance).
I'd like to see some explanation along these lines:
"When using request.ip
as a key, you can also match against IP address ranges (expressed in CIDR notation). To do so, add a special $index
key to your external data source records, like so:"
It also might make sense to move this up, next to the "Foreign Key" heading?
@@ -33,7 +33,7 @@ See the pages in this section for more information on our example data sources, | |||
|
|||
Any external data source integration requires the following settings: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Side note: I don't think this is accurate. I think the last four settings are optional ("Headers", "Allow Insecure TLS", "Polling Min/Max Delay", "Client TLS Key").
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I was actually looking for "Allow Insecure TLS" in the Console UI and couldn't find it at all. I'll submit an issue to update this page, but it's not a high priority in my opinion at the moment.
Co-authored-by: Kenneth Jenkins <[email protected]>
Co-authored-by: Kenneth Jenkins <[email protected]>
Co-authored-by: Kenneth Jenkins <[email protected]>
* adds ip range lookup support * updates text * runs prettier * updates text and moves section * Update content/docs/integrations.mdx Co-authored-by: Kenneth Jenkins <[email protected]> * Update content/docs/integrations.mdx Co-authored-by: Kenneth Jenkins <[email protected]> * Update content/docs/integrations.mdx Co-authored-by: Kenneth Jenkins <[email protected]> --------- Co-authored-by: Kenneth Jenkins <[email protected]>
Adds ip range lookup support (#1262) * adds ip range lookup support * updates text * runs prettier * updates text and moves section * Update content/docs/integrations.mdx * Update content/docs/integrations.mdx * Update content/docs/integrations.mdx --------- Co-authored-by: zachary painter <[email protected]> Co-authored-by: Kenneth Jenkins <[email protected]>
This PR adds a section to our Integrations page explaining the CIDR indexing support for external data sources.
Resolves https://github.com/pomerium/internal/issues/1737