Updates Docker pull URLs #1276
Merged
Updates Docker pull URLs #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZPain8464
requested review from
calebdoxsey,
wasaga,
desimone,
nhayfield,
ssveta7ak,
kenjenkins and
cmo-pomerium
✅ Deploy Preview for pomerium-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kenjenkins
approved these changes
Mar 2, 2024
content/docs/deploy/core.mdx
Outdated
There was a problem hiding this comment.
Should this still mention Docker Hub on line 85?
| @@ -4,7 +4,7 @@ networks: | |||
| main: {} | |||
| services: | |||
| pomerium: | |||
| image: pomerium/pomerium:v0.21.1 | |||
| image: cr.pomerium.com/pomerium/pomerium:v0.21.1 | |||
There was a problem hiding this comment.
I noticed you updated a v0.23.0 tag to latest above. Should we do the same here, or is there some reason this needs to use an older version?
There was a problem hiding this comment.
The guide was written to be compatible with v0.21, which requires a service-level network attribute in the Docker Compose file. We had to update the v0.21 Quickstart to do this as well. We haven't updated this guide in some time, so I thought it best to keep the current Pomerium version.
backport-actions-token bot
pushed a commit
that referenced
this pull request
Mar 5, 2024
updates Docker pull URLs
ZPain8464
added a commit
that referenced
this pull request
Mar 5, 2024
Updates Docker pull URLs (#1276) updates Docker pull URLs Co-authored-by: zachary painter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all instances of the Docker pull URL in our docs. I may have missed a few, so I'd appreciate a quick review from the team.
I backported to v0.25, but we could also backport to previous versions. Thoughts or opinions here?
resolves https://github.com/pomerium/internal/issues/1741