adds query strings to IdP guides #1302
Merged
+72
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pomerium-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@kenjenkins I've updated this to remove |
kenjenkins
approved these changes
Mar 18, 2024
|
|
||
| Unfortunately, Google does not yet support getting groups data using a custom claim. Groups must be loaded by using a plugin to fetch directory information (see Enterprise's Directory Sync). | ||
| Unfortunately, Google doesn't support getting groups data with a custom claim. To get and use groups data from your Google directory, you must conduct a directory sync in the Enterprise Console. |
There was a problem hiding this comment.
I think I've mentioned this before, but "conduct a directory sync" makes this sound like a one-time event. I'd suggest we phrase this more like "enable directory sync" to help reflect that directory sync is a recurring process.
There was a problem hiding this comment.
I think this stems from a misunderstanding on my part of how directory sync works. I thought it was a one-time sync, I'll update. Thanks for catching that.
backport-actions-token bot
pushed a commit
that referenced
this pull request
Mar 18, 2024
* updates auth0 and azure guides * adds querystring to idp guides * removes tabs from Google idp guide * runs prettier * runs prettier * fixes formatting issue * updates text
ZPain8464
added a commit
that referenced
this pull request
Mar 18, 2024
adds query strings to IdP guides (#1302) * updates auth0 and azure guides * adds querystring to idp guides * removes tabs from Google idp guide * runs prettier * runs prettier * fixes formatting issue * updates text Co-authored-by: zachary painter <60552605+ZPain8464@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds query strings to Tabs. Now, when you send a link that includes an anchor link within a Tab, the page will scroll to the correct location.
Note: I did add
queryStringto the Config and Envar Tabs, too. If you click one of these tabs, and then click another Tab in a separate block, with a query string, it will conjoin them. For example:Selecting
baz-aand thenbar-bwould result in a string like:?foo-a=baz-a&foo-b=bar-b. A real life example:/docs/identity-providers/github?configuration-settings=environment-variables&get-groups=directory-syncIt's entirely possible that user would unwittingly select both Tabs, which would break the functionality. I want the team's input, but maybe we should only add query strings to one tab block in a page going forward? Happy to document this internally.
Resolves #1288