Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates load balancing ref page #1318

Merged
merged 7 commits into from
Mar 25, 2024
Merged

Conversation

ZPain8464
Copy link
Contributor

@ZPain8464 ZPain8464 commented Mar 20, 2024

This PR documents Load Balancing Health Checks parameters, http health checks, tcp health checks, and grpc health checks. It adds definitions to the reference.json file. These docs were added to populate missing tooltips in Zero.

Resolves https://github.com/pomerium/internal/issues/1759

@ZPain8464 ZPain8464 requested a review from a team as a code owner March 20, 2024 15:53
@ZPain8464 ZPain8464 requested review from cmo-pomerium and removed request for a team March 20, 2024 15:53
Copy link

netlify bot commented Mar 20, 2024

Deploy Preview for pomerium-docs ready!

Name Link
🔨 Latest commit 1b36e13
🔍 Latest deploy log https://app.netlify.com/sites/pomerium-docs/deploys/660178ecaceb4d00087c2cc7
😎 Deploy Preview https://deploy-preview-1318--pomerium-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ZPain8464 ZPain8464 requested a review from wasaga March 21, 2024 16:02

See [Load Balancing](/docs/capabilities/load-balancing.md) for example [configurations](/docs/capabilities/load-balancing.md#active-health-checks).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we move examples here for consistency with other topics? (and expand the configuration examples to cover both core, enterprise and IC?)

@ZPain8464 ZPain8464 merged commit 4958fbe into main Mar 25, 2024
6 checks passed
@ZPain8464 ZPain8464 deleted the zpain/update-load-balancing-ref-page branch March 25, 2024 13:18
backport-actions-token bot pushed a commit that referenced this pull request Mar 26, 2024
* adds health check table to load balancing page

* adds health checks parameters and definitions

* runs prettier

* fixes typo

* updates reference file

* moves examples to lb reference page

* adds links
ZPain8464 added a commit that referenced this pull request Mar 26, 2024
Updates load balancing ref page (#1318)

* adds health check table to load balancing page

* adds health checks parameters and definitions

* runs prettier

* fixes typo

* updates reference file

* moves examples to lb reference page

* adds links

Co-authored-by: zachary painter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants