Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds pz routing video #1325

Merged
merged 2 commits into from
May 3, 2024
Merged

Adds pz routing video #1325

merged 2 commits into from
May 3, 2024

Conversation

ZPain8464
Copy link
Contributor

This is a draft PR with the Routing in PZ video. You can find the video on /docs/capabilities/routing.

Copy link

netlify bot commented Mar 25, 2024

Deploy Preview for pomerium-docs ready!

Name Link
🔨 Latest commit 635b8e9
🔍 Latest deploy log https://app.netlify.com/sites/pomerium-docs/deploys/662fa3a0537123000881fe4f
😎 Deploy Preview https://deploy-preview-1325--pomerium-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ZPain8464
Copy link
Contributor Author

My only concern is the video quality. It's somewhat blurry, which makes it hard to read tooltips and some of the text.

Copy link
Contributor

@cmo-pomerium cmo-pomerium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think this video is pretty good. Achieves everything we want out of them.

@desimone
Copy link
Collaborator

Why not on the fundamentals page (too?) seems more aligned

https://deploy-preview-1325--pomerium-docs.netlify.app/docs/courses/fundamentals/build-routes

@ZPain8464
Copy link
Contributor Author

The Pomerium Zero courses are a work in progress still. I have no problem adding it there, though.

@ZPain8464 ZPain8464 marked this pull request as ready for review March 27, 2024 17:37
@ZPain8464 ZPain8464 requested a review from a team as a code owner March 27, 2024 17:37
@ZPain8464
Copy link
Contributor Author

I need to re-shoot this, because the From: URL now provides a dropdown to select the schema.

@ZPain8464 ZPain8464 merged commit 7693552 into main May 3, 2024
8 checks passed
@ZPain8464 ZPain8464 deleted the zpain/routing-video branch May 3, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants