Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tcp proxy chaining support notice #1380

Merged
merged 12 commits into from
May 2, 2024
Merged

Conversation

ZPain8464
Copy link
Contributor

@ZPain8464 ZPain8464 commented Apr 30, 2024

Resolves #1377

@kenjenkins I assume this isn't available in Zero or Enterprise yet?

@ZPain8464 ZPain8464 requested a review from kenjenkins April 30, 2024 15:47
@ZPain8464 ZPain8464 requested a review from a team as a code owner April 30, 2024 15:47
@ZPain8464 ZPain8464 requested review from cmo-pomerium and removed request for a team April 30, 2024 15:47
Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for pomerium-docs ready!

Name Link
🔨 Latest commit 0038f5a
🔍 Latest deploy log https://app.netlify.com/sites/pomerium-docs/deploys/6633a1e695926c00090606c3
😎 Deploy Preview https://deploy-preview-1380--pomerium-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kenjenkins
Copy link
Contributor

I assume this isn't available in Zero or Enterprise yet?

I haven't tested it myself, but I don't think this requires any changes in Zero or Enterprise. We show a free-form input field for the route 'To' URL in both UIs, so users should be able to swap out "tcp://" for another URL scheme there.

Copy link
Contributor

@kenjenkins kenjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! I have a few suggestions on structure and phrasing, let me know if you have any questions or feedback.

to: http://second-proxy.example.corp.com:10003
```

:::info TCP examples
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My personal preference would be to keep a separate section heading for these links, as it's not really part of the preceding section.

Copy link
Contributor

@cmo-pomerium cmo-pomerium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grammar check rubber stamp

@ZPain8464 ZPain8464 requested a review from kenjenkins May 2, 2024 14:23
@ZPain8464 ZPain8464 merged commit f64ca1c into main May 2, 2024
8 checks passed
@ZPain8464 ZPain8464 deleted the zpain/tcp-proxy-chaining branch May 2, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document new TCP proxy chaining functionality
3 participants