Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move the default upstream timeout page to global-timeouts #1688

Merged
merged 4 commits into from
Nov 7, 2024
Merged

move the default upstream timeout page to global-timeouts #1688

merged 4 commits into from
Nov 7, 2024

Conversation

calebdoxsey
Copy link
Contributor

Fixes #1637

@calebdoxsey calebdoxsey requested a review from a team as a code owner November 7, 2024 20:57
@calebdoxsey calebdoxsey requested review from cmo-pomerium and removed request for a team November 7, 2024 20:57
@netlify Netlify
Copy link

netlify bot commented Nov 7, 2024 •
edited
Loading

✅ Deploy Preview for pomerium-docs ready!

Name Link
🔨 Latest commit 3cedc11
🔍 Latest deploy log https://app.netlify.com/sites/pomerium-docs/deploys/672d30124d48d70008f1169a
😎 Deploy Preview https://deploy-preview-1688--pomerium-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kenjenkins
Copy link
Contributor

Netlify logs have this:

1:01:48 PM:   Exhaustive list of all broken links found:
1:01:48 PM:   - Broken link on source page path = /docs/internals/connection:
1:01:48 PM:      -> linking to /docs/reference/default-upstream-timeout

@calebdoxsey calebdoxsey merged commit 57c2069 into main Nov 7, 2024
8 checks passed
@calebdoxsey calebdoxsey deleted the cdoxsey/move-default-upstream-timeout branch November 7, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjenkins kenjenkins kenjenkins approved these changes

@cmo-pomerium cmo-pomerium Awaiting requested review from cmo-pomerium cmo-pomerium is a code owner automatically assigned from pomerium/docs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should "Default Upstream Timeout" be consolidated with the "Global Timeouts" page?
2 participants
@calebdoxsey @kenjenkins