Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update _redirects to match new sitemap (27 vs 28) and reorganized docs #1755

Merged
merged 4 commits into from
Jan 23, 2025

Conversation

desimone
Copy link
Collaborator

@desimone desimone commented Jan 23, 2025

  • Added redirects for old capabilities pages (hosted-authenticate-service, mtls-clients, etc.).
  • Updated Helm references to point to /docs/deploy/k8s/install.
  • Removed outdated references (pre 0.20) and consolidated rules to avoid 404s.
  • Grouped rules logically by doc category for easier maintenance.

Follow-up to #1726

@desimone desimone requested a review from a team as a code owner January 23, 2025 05:26
@desimone desimone requested review from nickytonline and removed request for a team January 23, 2025 05:26
Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for pomerium-docs ready!

Name Link
🔨 Latest commit 4338f82
🔍 Latest deploy log https://app.netlify.com/sites/pomerium-docs/deploys/6791df865abdf500083a3b8a
😎 Deploy Preview https://deploy-preview-1755--pomerium-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@desimone desimone added 404 Routes that are 404'ing that should be 302'ing backport 0-28-0 labels Jan 23, 2025
/guide/synology /docs/guides/synology
/guide/synology.html /docs/guides/synology
/docs/quick-start/synology.html /docs/guides/synology
/docs/guides/jwt-verification /docs/deploy/jwt-verification-with-envoy

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all incredibly incredibly old.

@desimone desimone changed the title fix redirects chore: update _redirects to match new sitemap (27 vs 28) and reorganized docs Jan 23, 2025
@desimone desimone enabled auto-merge (squash) January 23, 2025 06:25
Copy link
Contributor

@rjbeers rjbeers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably more good than damage to merge this as is, so I'm marking as approved, even though there are possible changes.

I reviewed the new links one by one, but didn't do much of anything to review the existing redirects vs what they were replaced with. If that needs review, let me know, and maybe i'll script to make sure they don't 404 or something.

/docs/security.html /docs/internals/security
/docs/community/security.html /docs/internals/security
# Root => /docs
/ /docs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have a 301! at the end to force the redirect even though we have a blank / page. I closed my PR to fix this, because of conflicts, so we can add it here, or I'll follow up with a new PR to add it.

@desimone desimone merged commit e8fac79 into main Jan 23, 2025
8 checks passed
rjbeers

This comment was marked as duplicate.

@desimone desimone deleted the bobby/eng-1933-fix-404s branch January 23, 2025 15:44
backport-actions-token bot pushed a commit that referenced this pull request Jan 23, 2025
…zed docs (#1755)

- Added redirects for old capabilities pages (hosted-authenticate-service, mtls-clients, etc.).
- Updated Helm references to point to /docs/deploy/k8s/install.
- Removed outdated references (pre 0.20) and consolidated rules to avoid 404s.
- Grouped rules logically by doc category for easier maintenance.

Follow-up to [#1726](#1726)
desimone added a commit that referenced this pull request Jan 23, 2025
…zed docs (#1756)

chore: update _redirects to match new sitemap (27 vs 28) and reorganized docs (#1755)

- Added redirects for old capabilities pages (hosted-authenticate-service, mtls-clients, etc.).
- Updated Helm references to point to /docs/deploy/k8s/install.
- Removed outdated references (pre 0.20) and consolidated rules to avoid 404s.
- Grouped rules logically by doc category for easier maintenance.

Follow-up to [#1726](#1726)

Co-authored-by: bobby <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
404 Routes that are 404'ing that should be 302'ing backport 0-28-0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants