rewrite all-in-one vs split-service #1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaurdro
requested review from
rjbeers and
tsullyo
and removed request for
a team
✅ Deploy Preview for pomerium-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kenjenkins
approved these changes
Mar 5, 2025
Co-authored-by: Kenneth Jenkins <[email protected]>
Co-authored-by: Kenneth Jenkins <[email protected]>
backport-actions-token bot
pushed a commit
that referenced
this pull request
Mar 7, 2025
* rewrite all-in-one vs split-service * pre-commit changes * Update content/docs/internals/configuration.mdx Co-authored-by: Kenneth Jenkins <[email protected]> * Apply suggestions from code review Co-authored-by: Kenneth Jenkins <[email protected]> * remove redundant sentence --------- Co-authored-by: Kenneth Jenkins <[email protected]>
kenjenkins
added a commit
that referenced
this pull request
Mar 7, 2025
rewrite all-in-one vs split-service (#1797) * rewrite all-in-one vs split-service * pre-commit changes * Update content/docs/internals/configuration.mdx * Apply suggestions from code review * remove redundant sentence --------- Co-authored-by: Ross Smith <[email protected]> Co-authored-by: Kenneth Jenkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes the split service keyword to reduce chances of landing here.
updates language to reflect the preferred and default choice is all-in-one and split-mode has uses,but they're very specific.