-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assigning svc CLuster IP when svc is a NodePort #1099
base: main
Are you sure you want to change the base?
Conversation
I'm not sure this is an allowed behaviour, please see kubernetes/kubernetes#119700 |
hey @wasaga, thanks for your time, so I inspired the implementation from nginx-ingress code because we were wondering why it was working for inrgess-nginx and not for pomerium |
@wasaga I updated the branch, can you check if everything is good so we can merge it ? |
Sorry to clarify my comment, I meant that ClusterIP should be excluded in this logic, and only handle LoadBalancer or NodePort. |
@kralicky done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hey @wasaga, do you have a moment please to review the PR ! |
@hamzabouissi could you please fix the compilation issue |
@wasaga, can you check please |
Summary
Related issues
Checklist
improvement
/bug
/ etc)