Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle resource not found #24

Merged
merged 1 commit into from
Jan 9, 2025
Merged

handle resource not found #24

merged 1 commit into from
Jan 9, 2025

Conversation

wasaga
Copy link
Collaborator

@wasaga wasaga commented Jan 9, 2025

if a resource was created and exists in a plan, but was deleted outside of terraform, it would return an error during Read.
this PR handles NotFound response and removes the resource from plan, so that it would get re-created.

Fixes https://linear.app/pomerium/issue/ENG-1782/provider-doesnt-handle-route-deletion-correctly

@wasaga wasaga requested a review from a team as a code owner January 9, 2025 02:15
@wasaga wasaga requested review from kralicky and calebdoxsey January 9, 2025 02:15
@wasaga wasaga merged commit 5105d40 into main Jan 9, 2025
3 checks passed
@wasaga wasaga deleted the wasaga/handle-not-found branch January 9, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants