service-accounts: add jwts, better handling of user id #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebdoxsey
changed the title
wasaga
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
jwtproperty to the output of service accounts. This is only populated on creation but will be stored in the terraform state.User IDs are somewhat confusing with service accounts. There are two cases:
namespace_idis null whenAddPomeriumServiceAccountis called the user ID of the service account will be set to what the user enters.namespace_idis not null whenAddPomeriumServiceAccountis called the user ID will have@{NAMESPACE-ID}.pomeriumadded to it.To reflect this behavior, use the
namefield, which doesn't exist in the enterprise console, to represent the user ID without the added@....