Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ppl: handle unknown state #28

Merged
merged 1 commit into from
Jan 24, 2025
Merged

ppl: handle unknown state #28

merged 1 commit into from
Jan 24, 2025

Conversation

wasaga
Copy link
Collaborator

@wasaga wasaga commented Jan 24, 2025

If PPL block was referencing some values that were unknown, it still tried to parse the PPL. Instead, it should return an unknown state as well.
Similarly for null values.

Fixes https://linear.app/pomerium/issue/ENG-1936

@wasaga wasaga requested a review from a team as a code owner January 24, 2025 03:25
@wasaga wasaga merged commit 59e119d into main Jan 24, 2025
3 checks passed
@wasaga wasaga deleted the wasaga/handle-unknown-ppl-state branch January 24, 2025 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants