add global jwt_issuer_format option #52
Open
+127
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wasaga
reviewed
Mar 14, 2025
internal/provider/convert.go
Outdated
| // ToIssuerFormat converts a JWT issuer format string into a protobuf enum. | ||
| func ToIssuerFormat(src types.String) *pb.IssuerFormat { | ||
| switch src.ValueString() { | ||
| case "host_only", "hostOnly": // the Core YAML config expects 'hostOnly' |
There was a problem hiding this comment.
I don't think you can do alternative names with just a String base type - that would require a custom type - otherwise i.e. if you use hostOnly originally in your .tf file, next time the configuration is read, the FromIssuerFormat would return host_only value and terraform would think configuration was changed.
for simplicity we need to use just one variant.
| case "uri": | ||
| return pb.IssuerFormat_IssuerURI.Enum() | ||
| default: | ||
| return nil |
There was a problem hiding this comment.
I think we need to differentiate between a nil or unknown string (results in a nil) and a value that we did not recognize (results in an error)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: https://linear.app/pomerium/issue/ENG-2072/config-jwt-issuer-format-should-also-be-support-at-the-global-level