Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove failing test #20

Merged
merged 1 commit into from
Jun 28, 2022
Merged

remove failing test #20

merged 1 commit into from
Jun 28, 2022

Conversation

calebdoxsey
Copy link
Collaborator

Summary

This test is failing due to an expired certificate. I was not able to find another sample response for android safety net. I don't even know what android safety net is. I believe the test failure only happens on a mac. Manually setting the current time in the verify options did not fix the test, so I don't know how we can circumvent the failure, except to get a new response, which I don't know how to get.

Related issues

Fixes #17

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey added the enhancement New feature or request label Jun 27, 2022
@calebdoxsey calebdoxsey merged commit ba70e10 into main Jun 28, 2022
@calebdoxsey calebdoxsey deleted the cdoxsey/safety-net-test branch June 28, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unit test depends on expired pre-generated cert
2 participants