Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add table of timings #12942

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −0
Open

add table of timings #12942

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions wiki/Gameplay/Judgement/osu!taiko/en.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@
| ![](/wiki/shared/judgement/osu!taiko/taiko-hit100k.png) ![](/wiki/shared/judgement/osu!taiko/taiko-hit100.png) | OK | 150 | 50% | `120 - 8 × OD` if OD ≤ 5, and `110 - 6 × OD` if OD ≥ 5 |
| ![](/wiki/shared/judgement/osu!taiko/taiko-hit0.png) | MISS | 0 | 0% | `135 - 8 × OD` if OD ≤ 5, and `120 - 5 × OD` if OD ≥ 5 |

| | 0 | 1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 10 |

Check warning on line 13 in wiki/Gameplay/Judgement/osu!taiko/en.md

View workflow job for this annotation

GitHub Actions / changed files

remark-osu:table-cell-padding 

Empty cell should contain 2 spaces, not 11

Check warning on line 13 in wiki/Gameplay/Judgement/osu!taiko/en.md

View workflow job for this annotation

GitHub Actions / changed files

remark-osu:table-cell-padding 

Cell should be padded with 1 space, not 3

Check warning on line 13 in wiki/Gameplay/Judgement/osu!taiko/en.md

View workflow job for this annotation

GitHub Actions / changed files

remark-osu:table-cell-padding 

Cell should be padded with 1 space, not 3

Check warning on line 13 in wiki/Gameplay/Judgement/osu!taiko/en.md

View workflow job for this annotation

GitHub Actions / changed files

remark-osu:table-cell-padding 

Cell should be padded with 1 space, not 3

Check warning on line 13 in wiki/Gameplay/Judgement/osu!taiko/en.md

View workflow job for this annotation

GitHub Actions / changed files

remark-osu:table-cell-padding 

Cell should be padded with 1 space, not 3

Check warning on line 13 in wiki/Gameplay/Judgement/osu!taiko/en.md

View workflow job for this annotation

GitHub Actions / changed files

remark-osu:table-cell-padding 

Cell should be padded with 1 space, not 3

Check warning on line 13 in wiki/Gameplay/Judgement/osu!taiko/en.md

View workflow job for this annotation

GitHub Actions / changed files

remark-osu:table-cell-padding 

Cell should be padded with 1 space, not 3

Check warning on line 13 in wiki/Gameplay/Judgement/osu!taiko/en.md

View workflow job for this annotation

GitHub Actions / changed files

remark-osu:table-cell-padding 

Cell should be padded with 1 space, not 3

Check warning on line 13 in wiki/Gameplay/Judgement/osu!taiko/en.md

View workflow job for this annotation

GitHub Actions / changed files

remark-osu:table-cell-padding 

Cell should be padded with 1 space, not 3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| | 0 | 1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 10 |
Comparison of the hit window length for different OD values:
| OD | 0 | 1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 10 |

|-----------|-----|-----|-----|-----|-----|-----|-----|-----|-----|-----|-----|

Check warning on line 14 in wiki/Gameplay/Judgement/osu!taiko/en.md

View workflow job for this annotation

GitHub Actions / changed files

remark-osu:table-align-style 

Align row cells should have standard format and padding (expected: | :-- | :-- | :-- | :-- | :-- | :-- | :-- | :-- | :-- | :-- | :-- | :-- |)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
|-----------|-----|-----|-----|-----|-----|-----|-----|-----|-----|-----|-----|
| :-: | :-: | :-: | :-: | :-: | :-: | :-: | :-: | :-: | :-: | :-: | :-: |

| Great | 50 ms | 47 ms | 44 ms | 41 ms | 38 ms | 35 ms | 32 ms | 29 ms | 26 ms | 23 ms | 20 ms |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Great | 50 ms | 47 ms | 44 ms | 41 ms | 38 ms | 35 ms | 32 ms | 29 ms | 26 ms | 23 ms | 20 ms |
| Great | 50 ms | 47 ms | 44 ms | 41 ms | 38 ms | 35 ms | 32 ms | 29 ms | 26 ms | 23 ms | 20 ms |

| Ok | 120 ms | 112 ms | 104 ms | 96 ms | 88 ms | 80 ms | 74 ms | 68 ms | 62 ms | 56 ms | 50 ms |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Ok | 120 ms | 112 ms | 104 ms | 96 ms | 88 ms | 80 ms | 74 ms | 68 ms | 62 ms | 56 ms | 50 ms |
| Ok | 120 ms | 112 ms | 104 ms | 96 ms | 88 ms | 80 ms | 74 ms | 68 ms | 62 ms | 56 ms | 50 ms |

| Miss | 135 ms | 127 ms | 119 ms | 111 ms | 103 ms | 95 ms | 90 ms | 85 ms | 80 ms | 75 ms | 70 ms |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Miss | 135 ms | 127 ms | 119 ms | 111 ms | 103 ms | 95 ms | 90 ms | 85 ms | 80 ms | 75 ms | 70 ms |
| Miss | 135 ms | 127 ms | 119 ms | 111 ms | 103 ms | 95 ms | 90 ms | 85 ms | 80 ms | 75 ms | 70 ms |


The hit window depends on the beatmap's [overall difficulty (OD)](/wiki/Beatmap/Overall_difficulty). A hit is then considered inside a hit window if `hit error < max hit error`, meaning the value listed is half of the hit window width. The MISS window by exception compares `hit error ≤ max hit error`<!-- internal reference: https://github.com/peppy/osu-stable-reference/blob/1531237b63392e82c003c712faa028406073aa8f/osu!/GameplayElements/HitObjects/Taiko/HitCircleTaiko.cs#L187, https://github.com/peppy/osu-stable-reference/blob/1531237b63392e82c003c712faa028406073aa8f/osu!/GameplayElements/HitObjects/Taiko/HitCircleTaiko.cs#L151 --> instead.

The hit error is rounded and the max hit error values are truncated to the nearest integer<!-- see corresponding reference in wiki/Gameplay/Judgement/osu!/en.md -->, meaning that for GREATs and OKs, hit windows may be up to 1.5 ms shorter on both sides, while miss windows may be up to 0.5 ms shorter or longer on both sides, than what the formulas suggest.
Expand Down
Loading