Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAJOR] Make clipboard and leaflet dependencies for NPM #2885

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/assets/javascripts/spotlight/admin/index.js
Original file line number Diff line number Diff line change
@@ -4,8 +4,8 @@
//= require parameterize
//= require bootstrap-tagsinput
//= require jquery.serializejson
//= require clipboard
//= require leaflet
//= require clipboard/dist/clipboard
//= require leaflet/dist/leaflet-src
//= require leaflet-iiif
//= require Leaflet.Editable
//= require Path.Drag
1 change: 1 addition & 0 deletions app/views/layouts/spotlight/base.html.erb
Original file line number Diff line number Diff line change
@@ -13,6 +13,7 @@
<% else %>
<%= stylesheet_link_tag "application" %>
<% end %>
<link rel="stylesheet" href="https://unpkg.com/leaflet@1.9.3/dist/leaflet.css" integrity="sha256-kLaT2GOSpHechhsozzB+flnD+zUyjE2LlfWPgU04xyI=" crossorigin="" />
<%= javascript_include_tag "application" %>
<%= csrf_meta_tags %>
<%= content_for(:head) %>
2 changes: 0 additions & 2 deletions blacklight-spotlight.gemspec
Original file line number Diff line number Diff line change
@@ -29,7 +29,6 @@ these collections.)
s.add_dependency 'breadcrumbs_on_rails', '>= 3.0', '< 5'
s.add_dependency 'cancancan'
s.add_dependency 'carrierwave', '~> 2.2'
s.add_dependency 'clipboard-rails', '~> 1.5'
s.add_dependency 'devise', '~> 4.1'
s.add_dependency 'devise_invitable'
s.add_dependency 'faraday'
@@ -41,7 +40,6 @@ these collections.)
s.add_dependency 'i18n-active_record'
s.add_dependency 'iiif_manifest'
s.add_dependency 'iiif-presentation'
s.add_dependency 'leaflet-rails'
s.add_dependency 'legato'
s.add_dependency 'mini_magick'
s.add_dependency 'nokogiri'
5 changes: 5 additions & 0 deletions lib/generators/spotlight/install_generator.rb
Original file line number Diff line number Diff line change
@@ -35,6 +35,11 @@ def add_js_rails7
append_to_file 'app/assets/javascripts/application.js', "\n//= require_tree .\n"
end

def add_js_deps
say 'Install Clipboard & Leaflet'
run 'yarn add clipboard@1.7.1 leaflet@^1.9.3'
end

def add_manifest
append_to_file 'app/assets/config/manifest.js', "\n//= link spotlight/manifest.js"
end
1 change: 0 additions & 1 deletion lib/generators/spotlight/templates/spotlight.scss
Original file line number Diff line number Diff line change
@@ -4,5 +4,4 @@
@import 'spotlight/variables_bootstrap';
@import 'bootstrap';
@import 'sir-trevor/main';
@import 'leaflet';
@import 'spotlight/spotlight';
4 changes: 2 additions & 2 deletions lib/spotlight/engine.rb
Original file line number Diff line number Diff line change
@@ -9,12 +9,10 @@
require 'activejob-status'
require 'autoprefixer-rails'
require 'blacklight'
require 'clipboard/rails'
require 'faraday'
require 'faraday/follow_redirects'
require 'friendly_id'
require 'i18n/active_record'
require 'leaflet-rails'
require 'paper_trail'
require 'riiif'
require 'spotlight/riiif_service'
@@ -66,6 +64,8 @@ class Engine < ::Rails::Engine
end

initializer 'spotlight.assets.precompile' do |app|
config.assets.paths << Rails.root.join('node_modules')

app.config.assets.precompile += %w[spotlight/default_thumbnail.jpg spotlight/default_browse_thumbnail.jpg]

Sprockets::ES6.configuration = { 'modules' => 'umd', 'moduleIds' => true }
2 changes: 2 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
@@ -25,5 +25,7 @@
"not IE 11"
],
"dependencies": {
"clipboard": "1.7.1",
"leaflet": "^1.9.3"
}
}