feat(controller): add SkipImpersonationReview featuregate #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prometherion
requested changes
Apr 11, 2024
Signed-off-by: Oliver Bähler <[email protected]>
oliverbaehler
force-pushed
the
feat/skip-impersonation-rewview
branch
from
8ee20ae to
31df01f
Compare
oliverbaehler
changed the title
oliverbaehler
changed the title
|
It would make sense @prometherion. |
prometherion
approved these changes
Apr 25, 2024
|
I think we can merge this, it's a +1 for me. We also need efforts to document this on the Capsule documentation regarding the Proxy. |
|
LGMT |
maxgio92
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this feature you can disable the capsule proxy to review the impersonated properties. Scenarios where this might be relevant are describe in the issue: #420
It also fixes the other properties for the impersonation which were added with:
They should be also functional, no clue where these changes got lost :D
Closes #420 🍀