Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added methods that retrieves the corresponding bytes by specifying a virtual address. #45

Merged
merged 6 commits into from
Mar 10, 2025

Conversation

Xornet-Euphoria
Copy link
Contributor

Added methods that retrieves the corresponding bytes by specifying a virtual address.

What's this Pull Request for?

Choose one or more of the following items.

  • Bug fix
  • Add/Remove feature
  • Cleaning code (including optimization/typo fix)
  • Others

Please explain the detail here:

[ja (for author)]
仮想アドレスを指定すると該当するバイト列を取得するメソッドを追加しました。

[en (for other contributers)]
Added methods that retrieves the corresponding bytes by specifying a virtual address.

What have you done so far?

Tell me what you've tested to assure your change is right.

  • All tests passed on your machine (python -m unittest)
  • Added test cases for new feature
  • Nothing / Test not required

(It's not mandatory to check even one of them, but test cases make it easy for the author to review your PR.)

Comment

@ptr-yudai
Copy link
Owner

PRありがとうございます
read_by_range は操作が自明なのでメソッドとして提供しなくても良い気がします。

@Xornet-Euphoria
Copy link
Contributor Author

取り出したいデータが大きい時、IDAやBinary Ninja、Ghidraからはサイズよりも終点を見ることが多いと思ってメソッドを用意しましたが、単純に差分がサイズなので「操作が自明」という指摘に従って削除しておきます。

@ptr-yudai ptr-yudai merged commit 5eefcfe into ptr-yudai:master Mar 10, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants