Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IOTA-SUI folder mismatch and restore correct structure in 'target_chains' #2517

Open
wants to merge 1 commit into
base: iota-contract-testnet
Choose a base branch
from

Conversation

pavlo-u
Copy link

@pavlo-u pavlo-u commented Mar 21, 2025

Summary

This PR resolves a folder mismatch issue in target_chains where the sui folder was overwritten with IOTA code. It:

  • Renames the current target_chains/sui folder (which contained IOTA code) to target_chains/iota to place the IOTA code in its proper directory.
  • Restores the original target_chains/sui folder from a previous commit to bring back Sui support.
  • Ensures IOTA and Sui have separate, correctly named directories within target_chains.

Rationale

The recent IOTA integration replaced the target_chains/sui folder with IOTA code instead of creating a dedicated target_chains/iota folder. This broke Sui support and misplaced IOTA code in the sui directory, where it didn’t belong. These changes are necessary to restore Sui functionality and relocate IOTA code to its intended location, maintaining proper separation of blockchain-specific code under target_chains.

How has this been tested?

  • Current tests cover my changes
  • Added new tests
  • Manually tested the code

I manually verified the changes by:

  1. Confirming the target_chains/iota folder now contains the IOTA-specific code, correctly relocated from sui.
  2. Confirming the target_chains/sui folder contains the restored Sui-specific code from commit <commit-hash> (replace with the actual hash).
  3. Checking that the folder structure under target_chains now correctly separates IOTA and Sui dependencies in their respective directories.

Note: If there are existing tests for Sui and IOTA integrations within target_chains, I recommend running them to ensure no regressions. I didn’t add new tests as this is a structural fix, but please advise if the tests need updating.

@pavlo-u pavlo-u requested a review from a team as a code owner March 21, 2025 22:36
Copy link

vercel bot commented Mar 21, 2025

@pavlo-u is attempting to deploy a commit to the Pyth Network Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant