Remove libcufile-dev packages from conda dependencies now that libkvikio is a shared library. #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kio is a shared library.
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a long time,
libkvikiowas a header-only library. To make it usable by consumers, we includedlibcufile-devin its run dependencies. Now thatlibkvikiois a shared library, we do not need to do that.Also, ARM packages of
libkvikiowere depending onlibcufileand getting it from thenvidiachannel, which breaks things because the version is unconstrained bycuda-version. We cannot include a run dependency onlibcufileon ARM until the next CUDA major version, because we need ARM packages to work with CUDA 12.0 andlibcufilewas only introduced in CUDA 12.2+.