Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation error under openSUSE Tumbleweed #667

Open
wants to merge 1 commit into
base: branch-25.04
Choose a base branch
from

Conversation

mrjoe7
Copy link

@mrjoe7 mrjoe7 commented Mar 14, 2025

It is not possible to compile the project under openSUSE Tumbleweed 20250224 (libstdc++6-devel-gcc14 14.2.1+git10750).

Without explicit #include <algorithm> I was getting the following error when running /build.sh libcudf in cudf project:

[ 34%] Built target libcurl_static
[ 34%] Building CXX object _deps/kvikio-build/CMakeFiles/kvikio.dir/src/shim/libcurl.cpp.o
/home/tomas/Development/playground/cudf/cpp/build/_deps/kvikio-src/cpp/src/shim/libcurl.cpp: In member function ‘void kvikio::CurlHandle::perform()’:
/home/tomas/Development/playground/cudf/cpp/build/_deps/kvikio-src/cpp/src/shim/libcurl.cpp:143:17: error: no matching function for call to ‘find(std::vector<int>::const_iterator, std::vector<int>::const_iterator, long int&)’
  143 |       (std::find(http_status_codes.begin(), http_status_codes.end(), http_code) !=
      |        ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/c++/14/bits/locale_facets.h:48,
                 from /usr/include/c++/14/bits/basic_ios.h:37,
                 from /usr/include/c++/14/ios:46,
                 from /usr/include/c++/14/ostream:40,
                 from /usr/include/c++/14/iostream:41,
                 from /home/tomas/Development/playground/cudf/cpp/build/_deps/kvikio-src/cpp/src/shim/libcurl.cpp:21:
/usr/include/c++/14/bits/streambuf_iterator.h:435:5: note: candidate: ‘template<class _CharT2> typename __gnu_cxx::__enable_if<std::__is_char<_CharT2>::__value, std::istreambuf_iterator<_CharT, std::char_traits<_CharT> > >::__type std::find(istreambuf_iterator<_CharT, char_traits<_CharT> >, istreambuf_iterator<_CharT, char_traits<_CharT> >, const _CharT2&)’
  435 |     find(istreambuf_iterator<_CharT> __first,
      |     ^~~~
/usr/include/c++/14/bits/streambuf_iterator.h:435:5: note:   template argument deduction/substitution failed:
/home/tomas/Development/playground/cudf/cpp/build/_deps/kvikio-src/cpp/src/shim/libcurl.cpp:143:17: note:   ‘__gnu_cxx::__normal_iterator<const int*, std::vector<int> >’ is not derived from ‘std::istreambuf_iterator<_CharT, std::char_traits<_CharT> >’
  143 |       (std::find(http_status_codes.begin(), http_status_codes.end(), http_code) !=
      |        ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
gmake[2]: *** [_deps/kvikio-build/CMakeFiles/kvikio.dir/build.make:345: _deps/kvikio-build/CMakeFiles/kvikio.dir/src/shim/libcurl.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:2268: _deps/kvikio-build/CMakeFiles/kvikio.dir/all] Error 2
gmake: *** [Makefile:156: all] Error 2

@mrjoe7 mrjoe7 requested a review from a team as a code owner March 14, 2025 22:10
Copy link

copy-pr-bot bot commented Mar 14, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this header should be included. Thank you.

@bdice bdice added bug Something isn't working non-breaking Introduces a non-breaking change labels Mar 14, 2025
@bdice
Copy link
Contributor

bdice commented Mar 14, 2025

/ok to test

@bdice
Copy link
Contributor

bdice commented Mar 14, 2025

/merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants