Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFBUGS-148: [release-4.18] DFBUGS-148: Fix CVE-2024-39249: Force [email protected] via resolutions #1901

Open
wants to merge 1 commit into
base: release-4.18
Choose a base branch
from

Conversation

TimothyAsirJeyasing
Copy link
Contributor

The CVE-2024-39249 vulnerability was caused by older versions of async, which were being pulled by dependencies like http-server (via portfinder) and cypress (via getos).

Since these dependencies have not yet updated to a secure version of async, this commit enforces [email protected] using the resolutions field in package.json as a temporary workaround.

  • Added "async": "^3.2.6" in resolutions in package.json.
  • Ran yarn install, updating yarn.lock accordingly.
  • This resolution should be removed once upstream dependencies update async.

BZ: https://issues.redhat.com/browse/DFBUGS-148

@openshift-ci-robot
Copy link

@TimothyAsirJeyasing: No Jira issue with key CVE-2024 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

The CVE-2024-39249 vulnerability was caused by older versions of async, which were being pulled by dependencies like http-server (via portfinder) and cypress (via getos).

Since these dependencies have not yet updated to a secure version of async, this commit enforces [email protected] using the resolutions field in package.json as a temporary workaround.

  • Added "async": "^3.2.6" in resolutions in package.json.
  • Ran yarn install, updating yarn.lock accordingly.
  • This resolution should be removed once upstream dependencies update async.

BZ: https://issues.redhat.com/browse/DFBUGS-148

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Mar 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: TimothyAsirJeyasing
Once this PR has been reviewed and has the lgtm label, please assign sanjalkatiyar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TimothyAsirJeyasing TimothyAsirJeyasing changed the title Fix CVE-2024-39249: Force [email protected] via resolutions DFBUGS-148: [release-4.18] DFBUGS-148: Fix CVE-2024-39249: Force [email protected] via resolutions Mar 12, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Mar 12, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 12, 2025

@TimothyAsirJeyasing: This pull request references [Jira Issue DFBUGS-148](https://issues.redhat.com//browse/DFBUGS-148), which is invalid:

  • expected the bug to target the "odf-4.18" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

The CVE-2024-39249 vulnerability was caused by older versions of async, which were being pulled by dependencies like http-server (via portfinder) and cypress (via getos).

Since these dependencies have not yet updated to a secure version of async, this commit enforces [email protected] using the resolutions field in package.json as a temporary workaround.

  • Added "async": "^3.2.6" in resolutions in package.json.
  • Ran yarn install, updating yarn.lock accordingly.
  • This resolution should be removed once upstream dependencies update async.

BZ: https://issues.redhat.com/browse/DFBUGS-148

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

The CVE-2024-39249 vulnerability was caused by older versions of async, which were being pulled by dependencies like `http-server` (via portfinder) and `cypress` (via getos).

Since these dependencies have not yet updated to a secure version of async, this commit enforces [email protected] using the `resolutions` field in package.json as a temporary workaround.

- Added `"async": "^3.2.6"` in `resolutions` in package.json.
- Ran `yarn install`, updating `yarn.lock` accordingly.
- This resolution should be removed once upstream dependencies update async.

BZ: https://issues.redhat.com/browse/DFBUGS-148

Signed-off-by: Timothy Asir Jeyasingh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting jira/valid-reference Indicates that this PR references a valid jira ticket of any type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants