-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DFBUGS-148: [release-4.18] DFBUGS-148: Fix CVE-2024-39249: Force [email protected] via resolutions #1901
base: release-4.18
Are you sure you want to change the base?
Conversation
@TimothyAsirJeyasing: No Jira issue with key CVE-2024 exists in the tracker at https://issues.redhat.com/. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: TimothyAsirJeyasing The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@TimothyAsirJeyasing: This pull request references [Jira Issue DFBUGS-148](https://issues.redhat.com//browse/DFBUGS-148), which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
The CVE-2024-39249 vulnerability was caused by older versions of async, which were being pulled by dependencies like `http-server` (via portfinder) and `cypress` (via getos). Since these dependencies have not yet updated to a secure version of async, this commit enforces [email protected] using the `resolutions` field in package.json as a temporary workaround. - Added `"async": "^3.2.6"` in `resolutions` in package.json. - Ran `yarn install`, updating `yarn.lock` accordingly. - This resolution should be removed once upstream dependencies update async. BZ: https://issues.redhat.com/browse/DFBUGS-148 Signed-off-by: Timothy Asir Jeyasingh <[email protected]>
9b1dc2b
to
920632f
Compare
The CVE-2024-39249 vulnerability was caused by older versions of async, which were being pulled by dependencies like
http-server
(via portfinder) andcypress
(via getos).Since these dependencies have not yet updated to a secure version of async, this commit enforces [email protected] using the
resolutions
field in package.json as a temporary workaround."async": "^3.2.6"
inresolutions
in package.json.yarn install
, updatingyarn.lock
accordingly.BZ: https://issues.redhat.com/browse/DFBUGS-148