remove storagesystem controller #552
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
iamniting
force-pushed
the
storagesystem
branch
2 times, most recently
from
afac529 to
e0b5b3b
Compare
|
/test odf-operator-e2e-aws |
1 similar comment
|
/test odf-operator-e2e-aws |
iamniting
force-pushed
the
storagesystem
branch
5 times, most recently
from
0ad8db0 to
876f89e
Compare
There was a problem hiding this comment.
Why do we need to keep anything in this file or the file at all?
We just need to made sure the OpenAPI representation of this API is in the operator's bundle and this can be achieved even without have a go structs for the API
There was a problem hiding this comment.
We still need to watch, read, and delete via the other cleanup controller. Thats why we need it. Also for the console redirect purposes as well.
iamniting
force-pushed
the
storagesystem
branch
from
876f89e to
f93def5
Compare
Signed-off-by: Nitin Goyal <[email protected]>
Signed-off-by: Nitin Goyal <[email protected]>
Signed-off-by: Nitin Goyal <[email protected]>
Signed-off-by: Nitin Goyal <[email protected]>
Signed-off-by: Nitin Goyal <[email protected]>
iamniting
force-pushed
the
storagesystem
branch
from
f93def5 to
3a2d1be
Compare
|
@iamniting: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test odf-operator-e2e-aws |
Signed-off-by: Nitin Goyal [email protected]