Remove defunct mod/assignment #88
Conversation
There was a problem hiding this comment.
Glad to see someone tackled this. Looks fine except for your choice to remove the 'assign_submission' table in the test file: tests/fixtures/block_grade_me.xml
Could you please explain your reasoning for removing this table? It seems that this table is a part of the not-out-of-date 'assign' naming convention, thus it should be kept, no? I haven't looked a ton into this, but could you explain your reasoning a bit, or make a change to keep that particular table?
|
@Junosprite007 sorry I've been out of town. You are correct, I took out more of the xml than I should have there. Added back. |
|
Thank you for contributions here and my apologies if a merge-able PR was missed, as I had already started similar fixes for removal of old "Assignment" across all versions before I realized there was additional dialogue and commits on this issue. Please feel free to check against the new versions v4.3.0.1 / v4.5.0.0 just released, and if all mod_assignment references appear to be removed for the applicable versions we can close this one out. |
|
Existing changes look good. Closing! Thanks! |
mod/assignment was removed in Moodle 4.2.
also fixes: #86