Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete join on query using course_modules #8

Open
wants to merge 1 commit into
base: MOODLE_31_STABLE
Choose a base branch
from
+1 −1
Open

Incomplete join on query using course_modules #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion classes/moodle/synchronize.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,7 @@ public function get_grade_and_completion_elements($courseids = []) {
JOIN {'.\pmclass::TABLE.'} cls ON cls.courseid = cmp.courseid
JOIN {'.\classmoodlecourse::TABLE.'} cmc ON cmc.classid = cls.id
AND cmc.moodlecourseid > 0 '.$courseidssql.'
LEFT JOIN {course_modules} crsmod ON crsmod.idnumber = cmp.idnumber
LEFT JOIN {course_modules} crsmod ON crsmod.idnumber = cmp.idnumber AND crsmod.course = cmc.moodlecourseid
LEFT JOIN {grade_items} gi
ON gi.courseid = cmc.moodlecourseid
AND (gi.idnumber = cmp.idnumber OR gi.idnumber = crsmod.id)';
Expand Down