[ROB-837] Pagerduty + JSM ticket support #334
Open
+539
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikalon1
previously approved these changes
Mar 19, 2025
| """ | ||
| Extracts and formats the issue description. | ||
| """ | ||
| description_blocks = ( |
There was a problem hiding this comment.
Is this logic the same for both Jira and JSM?
| description = self.extract_description(jira_issue) | ||
| return self.convert_to_issue(jira_issue, description) | ||
| except requests.RequestException as e: | ||
| raise ConnectionError(f"Failed to fetch Jira ticket {id}") from e |
| headers={"Accept": "application/json"}, | ||
| ) | ||
| response.raise_for_status() | ||
| jira_issue = response.json() |
| import logging | ||
|
|
||
|
|
||
| class ListAndBuildGrafanaDashboardURLs(Tool): |
There was a problem hiding this comment.
I think @aantn also implemented this
Are you two synced on this?
| label_key = "pod" if resource_type == "pod" else "app" | ||
|
|
||
| # Correct JSON structure to match the expected URL format | ||
| expected_query_params = { |
There was a problem hiding this comment.
Maybe not for the POC, but do you think we can make it completely generic?
i.e., let the llm build the loki query on it's own, to get link to logs on any resource.
This worked very well with OpenSearch, but I'm not familiar enough with Loki
| return | ||
| output_instructions = [] | ||
| # Validate Jira details if source is Jira Service Management | ||
| if source == SupportedTicketSources.JIRA_SERVICE_MANAGEMENT: |
There was a problem hiding this comment.
I would consider moving the creation if/else to another place, to prevent a huge if/else here
So this code doesn't have any source-specific code. (Just a thought)
So, it would be something like:
source_handler = SourceFactory.create_source(type, params)
try:
issue_to_investigate = source_handler.fetch_issue(id=ticket_id)
if issue_to_investigate is None:
raise Exception(f"Issue {ticket_id} Not found")
except Exception as e:
...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced Investigation Links for PagerDuty & Jira Service Management
Holmes now supports adding investigation links directly into PagerDuty and Jira Service Management tickets. This includes tools for generating Loki log links and Grafana dashboard links automatically.
Jira Service Management Example
To initiate an investigation and automatically post a comment with relevant links in a Jira Service Management ticket, run:
This will:
Example Output in Jira Service Management
PagerDuty Example
To run an investigation for a PagerDuty incident and add the results as a note:
poetry run python3 holmes.py investigate ticket \ --source pagerduty \ --ticket-api-key "KEY_HERE" \ --ticket-username "MY_EMAIL" \ --ticket-id "INCIDENT_ID_HERE" \ "QUERY HERE" # Example: "Generate Loki and Grafana links for this issue"This will:
Example Output in PagerDuty