-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: multiple candidates for method isIgnored. #135
base: master
Are you sure you want to change the base?
Conversation
Some runners, like Google's TestParameterInjector (https://github.com/google/TestParameterInjector), cause a situation where isIgnored has multiple candidates, causing MethodUtils.invokeMethod to fail.
@sbabcoc I'd really appreciate if you can submit and release this change. Apparently, this collides with TestParameterInjector, causing the test runner to fail. |
@idan-at Thank you for your submission! I really appreciate it. Please open an issue report that details the issue. It will be helpful to have a simple example that reproduces the issue which can be added to the unit test suite. |
Done, described it here: #136 |
Regarding the test - I’m not sure where to add it. If you guide me I’ll add one to this PR |
@idan-at The test shown in your issue report is exactly what I need. I have a big meeting today, so I may not be able to dig into this until tomorrow. |
The root cause of the issues you're running into is that JUnit-Foundation doesn't work with TestParameterInjector yet. Swallowing the exception isn't going to solve this problem. I've fixed the issue with "isIgnored", only to run into the same failure with "describeChild" farther on. |
I see. This doesn’t seem straightforward from a quick online search. WDYT about stating that retries do not currently work with this runner, together with somehow allowing to disable it (either manually or automatically) this will be helpful in my case, where I rely on this library only for global timeouts. |
I'm making progress, but a key feature (tracking of "atomic" tests) isn't working. I'll keep working on it tomorrow to see if I can get this working. |
Some runners, like Google's TestParameterInjector
(https://github.com/google/TestParameterInjector), cause a situation where isIgnored has multiple candidates, causing MethodUtils.invokeMethod to fail.