Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nan handling for continuous and categorical coloring #427

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Sonja-Stockhaus
Copy link
Collaborator

Fix coloring of shapes, labels and points when there are nan values in the vectors to color by

@Sonja-Stockhaus Sonja-Stockhaus linked an issue Mar 5, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 65.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 84.45%. Comparing base (478ab27) to head (da69a42).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/spatialdata_plot/pl/render.py 60.00% 12 Missing ⚠️
src/spatialdata_plot/pl/utils.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
+ Coverage   83.83%   84.45%   +0.62%     
==========================================
  Files           8        8              
  Lines        1732     1795      +63     
==========================================
+ Hits         1452     1516      +64     
+ Misses        280      279       -1     
Files with missing lines Coverage Δ
src/spatialdata_plot/pl/utils.py 78.40% <80.00%> (+0.39%) ⬆️
src/spatialdata_plot/pl/render.py 92.61% <60.00%> (+1.45%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Categorical color obs column crashes the plotting
2 participants