Upgrade packages #46
Upgrade packages #46
Conversation
|
Hi @pauldambra, could I get a review here please? |
| @@ -2,10 +2,9 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
| <PropertyGroup> | |||
| <OutputType>Exe</OutputType> | |||
| <TargetFramework>netcoreapp1.1</TargetFramework> | |||
| <TargetFramework>net9.0</TargetFramework> | |||
There was a problem hiding this comment.
i'm so far outside of the dot net ecosystem...
is this a breaking change for folk using older versions of .Net?
(i.e. they won't be able to include it any more)
There was a problem hiding this comment.
not against a version bump, just don't want to bump unnecessarily :)
There was a problem hiding this comment.
No, this is not part of the actual shipped library, so it doesn't matter much. I chose the latest SDK since it's just a sample. I had to upgrade since netcoreapp1.1 has been deprecated for years now.
| @@ -59,11 +51,11 @@ public void CanLogHelloWorld_WithDefaultFormatter() | |||
| [Fact] | |||
| public void CanLogHelloWorld_WithRawFormatter() | |||
| { | |||
| ConfigureTestLogger(new RawFormatter()); | |||
| var arbitraryMessage = nameof(WhenLoggingViaTCP) + "CanLogHelloWorld_WithRawFormatter" + Guid.NewGuid(); | |||
| ConfigureTestLogger(new CompactJsonFormatter()); | |||
There was a problem hiding this comment.
same question (from ignorance on my part here) does this change the format of the message significantly?
There was a problem hiding this comment.
It does change things a bit, but it still has no impact on the end-users. The RawFormatter is deprecated, so I replaced it. However, end-users can continue to use RawFormatter if they prefer. In this test case, the output is slightly different, but overall, I believe everything still works as expected.
|
Hi @pauldambra, could you re-run that Windows build again? |
|
consistently failing... i guess some setup problem 🤷 |
|
@pauldambra worked on my fork now: |
|
Thanks for merging this @pauldambra. If there is no process, would something linked to a tag make sense to set up? |
Hello @pauldambra, as a first step in #45
I would like to do some house keeping.