Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade react notfy toast to react 18 #2293

Conversation

Entkenntnis
Copy link
Member

It's mainly the big error messages that is irritating.

Using another tmp repository for this.

@Entkenntnis Entkenntnis linked an issue Apr 12, 2023 that may be closed by this pull request
@vercel
Copy link

vercel bot commented Apr 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Apr 12, 2023 0:26am

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Fifty-four Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 81.36 KB (🟡 +583 B) 172.77 KB
/404 32.33 KB (🟡 +583 B) 123.74 KB
/500 32.33 KB (🟡 +583 B) 123.74 KB
/[...slug] 63.45 KB (🟡 +583 B) 154.86 KB
/___bot_or_not 157.54 KB (🟡 +583 B) 248.94 KB
/___design 139.56 KB (🟡 +583 B) 230.96 KB
/auth/error 50.39 KB (🟡 +583 B) 141.8 KB
/auth/login 78.72 KB (🟡 +583 B) 170.13 KB
/auth/logout 70.54 KB (🟡 +583 B) 161.95 KB
/auth/oauth/consent 51.05 KB (🟡 +583 B) 142.46 KB
/auth/oauth/login 78.72 KB (🟡 +583 B) 170.13 KB
/auth/oauth/logout 70.54 KB (🟡 +583 B) 161.95 KB
/auth/recovery 58.57 KB (🟡 +583 B) 149.98 KB
/auth/registration 59.49 KB (🟡 +583 B) 150.89 KB
/auth/settings 59.57 KB (🟡 +583 B) 150.98 KB
/auth/verification 58.91 KB (🟡 +583 B) 150.31 KB
/authorization/roles 60.49 KB (🟡 +583 B) 151.9 KB
/backend 33.62 KB (🟡 +583 B) 125.03 KB
/biologie 145.56 KB (🟡 +583 B) 236.96 KB
/chemie 145.56 KB (🟡 +583 B) 236.96 KB
/consent 32.03 KB (🟡 +583 B) 123.44 KB
/content-only/[...slug] 62.76 KB (🟡 +583 B) 154.17 KB
/discussions 87.41 KB (🟡 +583 B) 178.82 KB
/editor 182.6 KB (🟡 +583 B) 274.01 KB
/entity/create/[type]/[taxonomyId] 662.02 KB (🟡 +583 B) 753.43 KB
/entity/license/update/[id] 53.09 KB (🟡 +583 B) 144.5 KB
/entity/link/order/[id]/link 143.14 KB (🟡 +583 B) 234.55 KB
/entity/repository/add-revision/[...id] 661.9 KB (🟡 +583 B) 753.31 KB
/entity/repository/compare/[entity_id]/[revision_id] 80.13 KB (🟡 +583 B) 171.54 KB
/entity/repository/history/[id] 64.26 KB (🟡 +583 B) 155.67 KB
/entity/taxonomy/update/[id] 110.36 KB (🟡 +583 B) 201.77 KB
/entity/unrevised 37.8 KB (🟡 +583 B) 129.21 KB
/event/history 207.86 KB (🟡 +583 B) 299.26 KB
/event/history/[...slug] 211.11 KB (🟡 +583 B) 302.52 KB
/informatik 145.56 KB (🟡 +583 B) 236.97 KB
/jobs/[[...jobId]] 42.04 KB (🟡 +583 B) 133.45 KB
/lerntipps 145.56 KB (🟡 +583 B) 236.97 KB
/license/detail/[id] 52.77 KB (🟡 +583 B) 144.18 KB
/mathe 145.55 KB (🟡 +583 B) 236.96 KB
/nachhaltigkeit 145.56 KB (🟡 +583 B) 236.97 KB
/page/create 661.73 KB (🟡 +583 B) 753.13 KB
/pages 54.3 KB (🟡 +583 B) 145.71 KB
/search 35.98 KB (🟡 +583 B) 127.39 KB
/spenden 44.29 KB (🟡 +583 B) 135.7 KB
/subscriptions/manage 106.23 KB (🟡 +583 B) 197.63 KB
/taxonomy/term/[copyOrMove]/batch/[id] 110.78 KB (🟡 +583 B) 202.19 KB
/taxonomy/term/create/[parent_id]/[id] 661.41 KB (🟡 +583 B) 752.82 KB
/taxonomy/term/sort/entities/[id] 143.19 KB (🟡 +583 B) 234.6 KB
/taxonomy/term/update/[id] 661.33 KB (🟡 +583 B) 752.73 KB
/user/[...userslug] 284.52 KB (🟡 +583 B) 375.93 KB
/user/me 31.38 KB (🟡 +583 B) 122.79 KB
/user/notifications 209.89 KB (🟡 +583 B) 301.3 KB
/user/settings 660.03 KB (🟡 +583 B) 751.44 KB
/uuid/recycle-bin 76.73 KB (🟡 +583 B) 168.14 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@Entkenntnis Entkenntnis merged commit b5dbfe4 into staging Apr 12, 2023
@Entkenntnis Entkenntnis deleted the 2124-notifyjs-reactdomrender-is-no-longer-supported-in-react-18 branch April 12, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

notify.js: ReactDOM.render is no longer supported in React 18
1 participant