Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use paper tick times method when available #217

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

radiant-ai
Copy link
Contributor

Partially fixes #208 by a use of Paper https://jd.papermc.io/paper/1.20/org/bukkit/Bukkit.html#getTickTimes()

I use this on my servers since 1.20.4 update and decided to share it

@sladkoff
Copy link
Owner

@radiant-ai Thanks for the contribution! ⭐

This also fixes #155, right?

@sladkoff sladkoff self-assigned this Jan 31, 2024
@radiant-ai
Copy link
Contributor Author

@radiant-ai Thanks for the contribution! ⭐

This also fixes #155, right?

Sorry, I did a mistake and accidentally merged experimental fix to async world size calculation there. I will revert that commit for now as it has some issues.

@radiant-ai
Copy link
Contributor Author

Now this includes only paper tick times support. I will fix world size calculation later and open another PR for that.

@sladkoff
Copy link
Owner

@radiant-ai No problem at all! Looking forward to your next PR then :)

@sladkoff sladkoff merged commit 247fc23 into sladkoff:master Jan 31, 2024
1 check passed
@sladkoff sladkoff added this to the 3.0.0 milestone Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] [1.20.4] Failed to find tick times buffer via reflection.
2 participants