Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-944787 Fix overflow when parsing values outside range of Int64 #1121

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

SNOW-944787 Fix overflow when parsing values outside range of Int64 #1121

wants to merge 1 commit into from

Conversation

tonic-brian
Copy link

SNOW-944787 Fix overflow when parsing values outside range of Int64

  • created a FastParser.TryFastParseInt64 that will return false instead throw an OverflowException
  • added check in SFDataConverter.ConvertToCSharpVal to return string if an overflow of Int64 would occur
  • added test cases to existing test TestConvertToInt64

(#797)

Description

Please explain the changes you made here.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@tonic-brian
SNOW-944787 Fix overflow when parsing values outside range of Int64
ff7cbed 
SNOW-944787 Fix overflow when parsing values outside range of `Int64`

- created a `FastParser.TryFastParseInt64` that will return false instead `throw` an `OverflowException`
- added check in `SFDataConverter.ConvertToCSharpVal` to return `string` if an overflow of `Int64` would occur
- added test cases to existing test `TestConvertToInt64`

(snowflakedb#797)
@tonic-brian tonic-brian requested a review from a team as a code owner March 20, 2025 16:21
@sfc-gh-snowflakedb-snyk-sa
Copy link
Contributor

sfc-gh-snowflakedb-snyk-sa commented Mar 20, 2025 •
edited
Loading

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 20, 2025 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@calexander3
Copy link

I have read the CLA Document and I hereby sign the CLA

@calexander3
Copy link

recheck

@tonic-brian
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tonic-brian @sfc-gh-snowflakedb-snyk-sa @calexander3