SNOW-1950183 Resolve Iceberg ingestion filename mismatch between upload and registration #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-dorlovsky
requested changes
Mar 6, 2025
src/test/java/net/snowflake/ingest/streaming/internal/it/SubscopedTokenRefreshIT.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/ingest/streaming/internal/SnowflakeFileTransferMetadataWithAge.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/ingest/streaming/internal/SnowflakeFileTransferMetadataWithAge.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/ingest/streaming/internal/InternalStage.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/ingest/streaming/internal/IcebergPostUploadMetadata.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/ingest/streaming/internal/InternalStage.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/ingest/streaming/internal/InternalStage.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/ingest/streaming/internal/InternalStage.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/ingest/streaming/internal/InternalStage.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/ingest/streaming/internal/InternalStage.java
Outdated
Show resolved
Hide resolved
sfc-gh-alhuang
force-pushed
the
alhuang-SNOW-1950183-iceberg-filename-mismatch
branch
from
15b60c3 to
7ac7194
Compare
sfc-gh-dorlovsky
requested changes
Mar 7, 2025
| @@ -17,8 +17,8 @@ interface IStorage { | |||
| * | |||
| * @param blobPath | |||
| * @param blob | |||
| * @return The String ETag returned by the upload. Can be null in situations where the underlying | |||
| * layer does not have an ETag to return. | |||
| * @return The IcebergPostUploadMetadata returned by the upload. Empty if and only if it is a | |||
There was a problem hiding this comment.
Nit: change to positive 'Present iff and only if the implementation is creating Iceberg blobs'.
Note that I prefer not to mention iceberg tables as long as we can abstract the storage interface away from them.
src/main/java/net/snowflake/ingest/streaming/internal/IcebergPostUploadMetadata.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/ingest/streaming/internal/IcebergPostUploadMetadata.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/ingest/streaming/internal/IcebergPostUploadMetadata.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/ingest/streaming/internal/InternalStage.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/ingest/streaming/internal/InternalStage.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/ingest/streaming/internal/InternalStage.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/ingest/streaming/internal/InternalStage.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/ingest/streaming/internal/InternalStage.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/ingest/streaming/internal/InternalStage.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/ingest/streaming/internal/InternalStage.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/ingest/streaming/internal/InternalStage.java
Outdated
Show resolved
Hide resolved
src/test/java/net/snowflake/ingest/streaming/internal/it/SubscopedTokenRefreshIT.java
Outdated
Show resolved
Hide resolved
...java/net/snowflake/ingest/streaming/internal/fileTransferAgent/IcebergFileTransferAgent.java
Outdated
Show resolved
Hide resolved
sfc-gh-dorlovsky
approved these changes
Mar 7, 2025
sfc-gh-alhuang
deleted the
alhuang-SNOW-1950183-iceberg-filename-mismatch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SDK has a bug when uploading Iceberg Parquet files at the moment of token expiration. It correctly uploads the file to S3 using a new token and file name but mistakenly registers it with the old file name. This PR ensure the SDK registers the file with the refreshed file name.
Server side fix for previous SDK versions.