Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1983454: Download required dependencies before release #961

Merged
merged 2 commits into from
Mar 17, 2025

Conversation

sfc-gh-anavalos
Copy link
Collaborator

There has been a connection error during the release of snowflake-ingest-java. The last 3 releases, including unshaded, had this issue.
Last time, shaded version was released skipping tests to unblock the release. The error is something like this:

00:11:41.344 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-jar-plugin:2.4:jar (default-jar) on project snowflake-ingest-sdk: Execution default-jar of goal org.apache.maven.plugins:maven-jar-plugin:2.4:jar failed: Plugin org.apache.maven.plugins:maven-jar-plugin:2.4 or one of its dependencies could not be resolved: Failed to collect dependencies at org.apache.maven.plugins:maven-jar-plugin:jar:2.4 -> org.apache.maven:maven-archiver:jar:2.5: Failed to read artifact descriptor for org.apache.maven:maven-archiver:jar:2.5: Could not transfer artifact org.apache.maven:maven-archiver:pom:2.5 from/to central (https://artifactory.int.snowflakecomputing.com/artifactory/development-maven-virtual): Connection reset -> [Help 1]

This PR split the release in the next stages:

  • do a clean compile
  • resolve dependencies
    • this also include the maven-archiver:pom:2.5 that is the one it fails to download on deploy
  • test
  • deploy
    • use parameter -Dhttp.keepAlive=false

Using this got the releases deployed to staging:
https://ci-dev-122.int.snowflakecomputing.com/job/MavenPushSnowpipeJavaSDK/75/
image

@sfc-gh-anavalos sfc-gh-anavalos requested review from sfc-gh-tzhang and a team as code owners March 14, 2025 18:30
@sfc-gh-snowflakedb-snyk-sa
Copy link
Contributor

sfc-gh-snowflakedb-snyk-sa commented Mar 14, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@sfc-gh-anavalos sfc-gh-anavalos merged commit c0a7675 into master Mar 17, 2025
51 checks passed
@sfc-gh-anavalos sfc-gh-anavalos deleted the sfc-gh-anavalos-test-shaded branch March 17, 2025 17:35
Comment on lines +84 to +85
echo "[INFO] mvn dependency resolve"
mvn dependency:resolve dependency:resolve-plugins dependency:go-offline -DmanualInclude=org.apache.maven:maven-archiver:pom:2.5 ${MVN_OPTIONS[@]}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced that this dependency is causing the issue, should we remove this and try if the deploy works or not first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants