SNOW-1947501: Create AST API in JDBC #2112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
sfc-gh-bli
reviewed
Mar 4, 2025
| @@ -787,7 +791,10 @@ public SFBaseResultSet execute( | |||
| throws SQLException, SFException { | |||
| TelemetryService.getInstance().updateContext(session.getSnowflakeConnectionString()); | |||
|
|
|||
| // todo: if (dataframeAst == null) | |||
| if (dataframeAst != null) { | |||
There was a problem hiding this comment.
Instead of return early, just use if statement to skip all sql functions, then we can benefit from feature changes related to non-sql part.
sfc-gh-rysun
changed the title
|
I have read the CLA Document and I hereby sign the CLA |
sfc-gh-bli
reviewed
Mar 6, 2025
| @@ -787,22 +791,23 @@ public SFBaseResultSet execute( | |||
| throws SQLException, SFException { | |||
| TelemetryService.getInstance().updateContext(session.getSnowflakeConnectionString()); | |||
|
|
|||
| // todo: if (dataframeAst == null) | |||
| sanityCheckQuery(sql); | |||
| if (dataframeAst == null) { | |||
There was a problem hiding this comment.
write a comment above this line, to mention why we skip those code.
| @@ -175,7 +175,13 @@ public ResultSet executeAsyncQuery(String sql) throws SQLException { | |||
| return rs; | |||
| } | |||
|
|
|||
| // todo: add doc | |||
| /** | |||
| * Execute SQL query asynchronously | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
SNOW-1947501
Pre-review self checklist
masterbranchmvn -P check-style validate)mvn verifyand inspecttarget/japicmp/japicmp.html)SNOW-XXXX:External contributors - please answer these questions before submitting a pull request. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Issue: #NNNN
Fill out the following pre-review checklist:
@SnowflakeJdbcInternalApi(note that public/protected methods/fields in classes marked with this annotation are already internal)Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.