-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1947501: Create AST API in JDBC #2112
Merged
sfc-gh-bli
merged 6 commits into
snowflakedb:dataframe_ast_poc
from
sfc-gh-rysun:dataframe_ast_poc
Mar 11, 2025
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
92203cd
Added params and finished Todos
sfc-gh-rysun 814e514
Fixed dataframe==null change and testing fixes
sfc-gh-rysun 7447314
Added dataframeAst to QueryExecDTO, passes basic test
sfc-gh-rysun d9e07a0
Resolve comments and add DataframeAst test
sfc-gh-rysun 68e86d7
Renamed function from Execute SQL->DataframeAST query
sfc-gh-rysun fc005b5
Added comment to describe if (dataframe == null)
sfc-gh-rysun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -175,7 +175,13 @@ public ResultSet executeAsyncQuery(String sql) throws SQLException { | |
return rs; | ||
} | ||
|
||
// todo: add doc | ||
/** | ||
* Execute SQL query asynchronously | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. asynchronously ? |
||
* | ||
* @param dataframeAst encoded string representation of the dataframe AST | ||
* @return ResultSet | ||
* @throws SQLException if @link{#executeQueryInternal(String, Map)} throws an exception | ||
*/ | ||
public ResultSet executeDataframeAst(String dataframeAst) throws SQLException { | ||
ExecTimeTelemetryData execTimeData = | ||
new ExecTimeTelemetryData("ResultSet Statement.executeQuery(String)", this.batchID); | ||
|
@@ -284,6 +290,7 @@ private void setQueryIdWhenValidOrNull(String queryId) { | |
* Internal method for executing a query with bindings accepted. | ||
* | ||
* @param sql sql statement | ||
* @param dataframeAst encoded string representation of the dataframe AST | ||
* @param asyncExec execute query asynchronously | ||
* @param parameterBindings parameters bindings | ||
* @return query result set | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of return early, just use if statement to skip all sql functions, then we can benefit from feature changes related to non-sql part.