Igarish snow 804145 streaming sdk gs rules #1382
Conversation
- fix pom.xml url - add sortpom plugin and sort pom.xml - remove internal repository reference - fix scm section - add a pluginManagement section - add version properties for plugins - update plugin versions - add dependency convergence and upper bounds checks - fill out dependencyManagement section to converge all dependencies at the upper bound - add unused declared and used undeclared dependency checks - remove unused declared dependencies - add used undeclared dependencies - fix the <scope> declaration of several dependencies - remove all dependency <exclusions> sections - remove maven-install-plugin - add japicmp plugin to enforce semantic versioning - update maven required version to 3.6.3 - add linkage checker enforcer rule - add linkage exclusions covering the current set of linkage issues - add duplicate class enforcer check from extra-enforcer-rules - adjust the java-9 profile to activate for jdks 9 or greater - add JPMS line for tests with jdk>8 "--add-opens=java.base/java.nio=ALL-UNNAMED" - update fmt-maven-plugin - add maven wrapper, pin maven to 3.8 for compatibility with linkage checker - disable shading by default, fixes #174 #608 - dependency fixes possibly fix #1211 - update json-smart to 2.4.9, related #1311 - httpclient to 4.5.14, #1273
… because java 8 in test infra doesn't support release flag.
This reverts commit dce748c.
This reverts commit bfd8df8.
sfc-gh-wshangguan
force-pushed
the
igarish-SNOW-804145-streaming-sdk-gs-rules
branch
from
53339f8 to
53f306d
Compare
sfc-gh-wshangguan
force-pushed
the
igarish-SNOW-804145-streaming-sdk-gs-rules
branch
from
a3c8a19 to
1c7f723
Compare
|
Changes since the original PR.
cc @sfc-gh-pbennes please review whether the above changes look good. |
|
@sfc-gh-igarish Please also review the change. I can't add you as reviewer since you created this PR. |
|
SonarQube Quality Gate
|
|
@sfc-gh-pbennes Thank you for the review, so for the linkage checker, it's enabled in non-fat-jar, which is used at least in jenkins test (not sure what's the case in github action). Does this sound good enough? About the non-fat-jar publish, sure, let's reserve a time to discuss it offline. |
|
Yeah that's a good first step. It might be tedious to add exclusions for the not-fat-jar for the initial internal inclusion but it should get better once the not-fat-jar is available to consume. |
|
LGTM |
There was a problem hiding this comment.
Verified that mvn clean install -Dnot-self-contained-jar generates non-shaded jar, while the default mvn clean install creates shaded-jar, I.e. no change to the default build behavior.
Approve on behalf of @sfc-gh-igarish .
Overview
SNOW-804145
This PR inherits the work from #1318. Basically adding changes to make it green in JDBC repo.
changes in original PR
#1318 (comment)
new changes on top of the original PR
#1382 (comment)
Note for the abnormal review / approval process.
The PR was originally created by @sfc-gh-igarish and then taken over by @sfc-gh-wshangguan . So @sfc-gh-igarish should be the reviewer in JDBC team. But since the PR creator can't approve the PR, @sfc-gh-wshangguan will give approval though he is the one who requested reviews. Next time should consider opening a new PR to avoid confusions.
External contributors - please answer these questions before submitting a pull request. Thanks!
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #NNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.
Pre-review checklist